From 9c02f976ae9b8dc6966da75c28469cca8c7e3f1f Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 2 Dec 2016 10:27:25 -0400 Subject: [PATCH] style: use GNU Make `foreach` instead of a shell for loop (#927) Just for conciseness and style. Signed-off-by: Juan Cruz Viotti --- Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index c253bb2e..01986afa 100644 --- a/Makefile +++ b/Makefile @@ -98,9 +98,7 @@ release/electron-$(TARGET_PLATFORM)-$(TARGET_ARCH)-app: \ release/electron-$(TARGET_PLATFORM)-$(TARGET_ARCH)-dependencies/node_modules \ release/electron-$(TARGET_PLATFORM)-$(TARGET_ARCH)-dependencies/bower_components ./scripts/unix/electron-create-resources-app.sh -s . -f "$(APPLICATION_FILES)" -o $@ - for prerequisite in $^; do \ - cp -rf $$prerequisite $@; \ - done + $(foreach prerequisite,$^,cp -rf $(prerequisite) $@;) release/electron-$(TARGET_PLATFORM)-$(TARGET_ARCH)-app.asar: \ release/electron-$(TARGET_PLATFORM)-$(TARGET_ARCH)-app