Refactor Sentry & Mixpanel properties

Change-type: patch
Changelog-entry: Refactor Sentry & Mixpanel properties
Signed-off-by: Lorenzo Alberto Maria Ambrosi <lorenzothunder.ambrosi@gmail.com>
This commit is contained in:
Lorenzo Alberto Maria Ambrosi 2019-10-03 21:09:42 +02:00
parent 284301a659
commit a736e69f9d

View File

@ -31,10 +31,18 @@ const configUrl = settings.get('configUrl') || 'https://balena.io/etcher/static/
const DEFAULT_PROBABILITY = 0.1
const services = {
sentry: sentryToken,
mixpanel: mixpanelToken
let services = {
sentry: null,
mixpanel: null
}
if (settings.get('errorReporting')) {
services = {
sentry: sentryToken,
mixpanel: mixpanelToken
}
}
resinCorvus.install({
services,
options: {
@ -42,7 +50,12 @@ resinCorvus.install({
shouldReport: () => {
return settings.get('errorReporting')
},
mixpanelDeferred: true
mixpanelDeferred: true,
sentryConfig: {
dataCallback: (object) => {
return _.omit(object, [ 'transaction', 'request.url' ])
}
}
}
})
@ -59,7 +72,12 @@ const initConfig = async () => {
const mixpanel = _.get(config, [ 'analytics', 'mixpanel' ], {})
mixpanelSample = mixpanel.probability || DEFAULT_PROBABILITY
if (isClientEligible(mixpanelSample)) {
validatedConfig = validateMixpanelConfig(mixpanel)
const defaultConfig = {
property_blacklist: [
'$current_url'
]
}
validatedConfig = _.merge(defaultConfig, validateMixpanelConfig(mixpanel))
}
} catch (err) {
resinCorvus.logException(err)