refactor: move lib/shared/child-writer to lib/child-writer (#1041)

The `child-writer` module is not re-used by both the GUI and the CLI, so
it makes sense to have it in `lib/child-writer`.

Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>

lib/child-writer/constants.js

@@ -29,7 +29,7 @@ module.exports = {
    * @property {String} PROJECT_ROOT
    * @memberof CONSTANTS
    */
-  PROJECT_ROOT: path.join(__dirname, '..', '..', '..'),
+  PROJECT_ROOT: path.join(__dirname, '..', '..'),
 
   /**
    * @property {String} WRITER_PROXY_SCRIPT

lib/child-writer/index.js

@@ -23,8 +23,8 @@ const ipc = require('node-ipc');
 const rendererUtils = require('./renderer-utils');
 const cli = require('./cli');
 const CONSTANTS = require('./constants');
-const EXIT_CODES = require('../exit-codes');
-const robot = require('../robot');
+const EXIT_CODES = require('../shared/exit-codes');
+const robot = require('../shared/robot');
 
 /**
  * @summary Perform a write

lib/child-writer/writer-proxy.js

@@ -25,8 +25,8 @@ const os = require('os');
 const path = require('path');
 const sudoPrompt = Bluebird.promisifyAll(require('sudo-prompt'));
 const utils = require('./utils');
-const EXIT_CODES = require('../exit-codes');
-const packageJSON = require('../../../package.json');
+const EXIT_CODES = require('../shared/exit-codes');
+const packageJSON = require('../../package.json');
 
 // This script is in charge of spawning the writer process and
 // ensuring it has the necessary privileges. It might look a bit

lib/gui/modules/image-writer.js

@@ -21,7 +21,7 @@
  */
 
 const angular = require('angular');
-const childWriter = require('../../shared/child-writer');
+const childWriter = require('../../child-writer');
 
 const MODULE_NAME = 'Etcher.Modules.ImageWriter';
 const imageWriter = angular.module(MODULE_NAME, [

package.json

@@ -11,7 +11,7 @@
     "url": "git@github.com:resin-io/etcher.git"
   },
   "scripts": {
-    "test": "npm run lint && electron-mocha --recursive --renderer tests/gui -R spec && electron-mocha --recursive tests/cli tests/shared -R spec",
+    "test": "npm run lint && electron-mocha --recursive --renderer tests/gui -R spec && electron-mocha --recursive tests/cli tests/shared tests/child-writer -R spec",
     "sass": "node-sass ./lib/gui/scss/main.scss > ./lib/gui/css/main.css",
     "jslint": "eslint lib tests scripts bin versionist.conf.js",
     "scsslint": "scss-lint lib/gui/scss",

tests/child-writer/cli.spec.js

@@ -17,9 +17,9 @@
 'use strict';
 
 const m = require('mochainon');
-const cli = require('../../../lib/shared/child-writer/cli');
+const cli = require('../../lib/child-writer/cli');
 
-describe('Shared: ChildWriter CLI', function() {
+describe('ChildWriter CLI', function() {
 
   describe('.getBooleanArgumentForm()', function() {
 

tests/child-writer/utils.spec.js

@@ -17,9 +17,9 @@
 'use strict';
 
 const m = require('mochainon');
-const utils = require('../../../lib/shared/child-writer/utils');
+const utils = require('../../lib/child-writer/utils');
 
-describe('Shared: ChildWriter Utils', function() {
+describe('ChildWriter Utils', function() {
 
   describe('.splitObjectLines()', function() {