jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-21 18:26:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): escape image path spaces correctly on Windows (#560)

Browse Source 
The `elevator` module passes its arguments directly to
`child_process.execFile()`, which handles escaping spaces and other
weird issues by default.

Instead of passing a separate argument for every word of the writer
proxy script command, we passed the whole thing at once, which means we
didn't get the escaping features by default.

Change-Type: patch
Changelog-Entry: Fix flashing not starting when an image name contains a space.
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-07-07 13:31:44 -04:00 committed by GitHub
parent b384a1d974
commit adcc13d474
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/src/child-writer/writer-proxy.js
View File

@ -82,17 +82,18 @@ return isElevated().then((elevated) => {
const elevator = Bluebird.promisifyAll(require('elevator')); const elevator = Bluebird.promisifyAll(require('elevator'));
return elevator.executeAsync([ return elevator.executeAsync([
[ 'set',
'ELECTRON_RUN_AS_NODE=1',
'set ELECTRON_RUN_AS_NODE=1 &&', '&&',
`set ${CONSTANTS.TEMPORARY_LOG_FILE_ENVIRONMENT_VARIABLE}=${logFile} &&`, 'set',
`${CONSTANTS.TEMPORARY_LOG_FILE_ENVIRONMENT_VARIABLE}=${logFile}`,
'&&',
// This is a trick to make the binary afterwards catch // This is a trick to make the binary afterwards catch
// the environment variables set just previously. // the environment variables set just previously.
'call' 'call'
].concat(process.argv).join(' ') ].concat(process.argv), {
], {
hidden: true, hidden: true,
terminating: true, terminating: true,
doNotPushdCurrentDirectory: true, doNotPushdCurrentDirectory: true,