jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-23 03:06:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): properly pass error object to "Flash error" event (#1619)

Browse Source 
Simply running `_.merge` on an Error object results in an empty plain
object `{}` being sent to Mixpanel/Sentry.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
This commit is contained in:
Juan Cruz Viotti 2017-07-23 23:32:50 -03:00 committed by GitHub
parent 1d66794450
commit b221914a3d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/gui/modules/image-writer.js
View File

@ -25,6 +25,7 @@ const _ = require('lodash');
const childWriter = require('../../child-writer'); const childWriter = require('../../child-writer');
const settings = require('../models/settings'); const settings = require('../models/settings');
const flashState = require('../../shared/models/flash-state'); const flashState = require('../../shared/models/flash-state');
const errors = require('../../shared/errors');
const windowProgress = require('../os/window-progress'); const windowProgress = require('../os/window-progress');
const analytics = require('../modules/analytics'); const analytics = require('../modules/analytics');
@ -134,7 +135,7 @@ imageWriter.service('ImageWriterService', function($q, $rootScope) {
analytics.logEvent('Out of space', analyticsData); analytics.logEvent('Out of space', analyticsData);
} else { } else {
analytics.logEvent('Flash error', _.merge({ analytics.logEvent('Flash error', _.merge({
error error: errors.toJSON(error)
}, analyticsData)); }, analyticsData));
} }