Merge pull request #2544 from balena-io/usbboot-limit-transfer-size

Usbboot limit transfer size

Makefile

@@ -201,7 +201,7 @@ lint-spell:
 	codespell \
 		--dictionary - \
 		--dictionary dictionary.txt \
-		--skip *.gz,*.bz2,*.xz,*.zip,*.img,*.dmg,*.iso,*.rpi-sdcard,.DS_Store,*.dtb,*.dtbo,*.dat,*.elf,*.bin,*.foo,xz-without-extension \
+		--skip *.svg *.gz,*.bz2,*.xz,*.zip,*.img,*.dmg,*.iso,*.rpi-sdcard,.DS_Store,*.dtb,*.dtbo,*.dat,*.elf,*.bin,*.foo,xz-without-extension \
 		lib tests docs scripts Makefile *.md LICENSE
 
 lint: lint-js lint-sass lint-cpp lint-html lint-spell

lib/sdk/adapters/usbboot/protocol.js

@@ -30,6 +30,8 @@ const usb = require('./usb')
 const NULL_BUFFER_SIZE = 0
 const NULL_BUFFER = Buffer.alloc(NULL_BUFFER_SIZE)
 
+const ONE_MEGABYTE = 1048576
+
 /**
  * @summary The size of the boot message bootcode length section
  * @type {Number}
@@ -206,6 +208,12 @@ exports.sendBufferSize = (device, size) => {
   })
 }
 
+const chunks = function *(buffer, size) {
+  for (let start = 0; start < buffer.length; start += size) {
+    yield buffer.slice(start, start + size)
+  }
+}
+
 /**
  * @summary Write a buffer to an OUT endpoint
  * @function
@@ -231,9 +239,11 @@ exports.write = (device, endpoint, buffer) => {
     .delay(USB_REQUEST_DELAY_MS)
 
     .then(() => {
-      return Bluebird.fromCallback((callback) => {
       endpoint.timeout = USB_BULK_TRANSFER_TIMEOUT_MS
-        endpoint.transfer(buffer, callback)
+      return Bluebird.each(chunks(buffer, ONE_MEGABYTE), (chunk) => {
+        return Bluebird.fromCallback((callback) => {
+          endpoint.transfer(chunk, callback)
+        })
       })
     })
 }