From b7aee7affecf3d62f7e7322b2decbc1c32fce73d Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Thu, 1 Dec 2016 19:52:27 -0400 Subject: [PATCH] chore: attempt to re-use $TMPDIR in `installer-appimage.sh` (#917) We currently hardcode the temporary directory location to `/tmp`. Some Linux systems define `$TMPDIR`, so we should attempt to re-use that first. Signed-off-by: Juan Cruz Viotti --- scripts/linux/electron-installer-appimage.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/linux/electron-installer-appimage.sh b/scripts/linux/electron-installer-appimage.sh index b8c45079..07f7b99b 100755 --- a/scripts/linux/electron-installer-appimage.sh +++ b/scripts/linux/electron-installer-appimage.sh @@ -102,10 +102,15 @@ else exit 1 fi +if [ -z "$TMPDIR" ]; then + TMPDIR=$(mktemp -d) +fi +mkdir -p "$TMPDIR" + OUTPUT_FILENAME="$ARGV_APPLICATION_NAME-linux-$ARGV_ARCHITECTURE.AppImage" # Create AppDir -APPDIR_PATH=/tmp/${OUTPUT_FILENAME%.*}.AppDir +APPDIR_PATH=$TMPDIR/${OUTPUT_FILENAME%.*}.AppDir APPDIR_ICON_FILENAME=icon rm -rf "$APPDIR_PATH" mkdir -p "$APPDIR_PATH/usr/bin" @@ -147,7 +152,7 @@ fi mkdir -p "$(dirname "$ARGV_OUTPUT")" rm -f "$ARGV_OUTPUT" -APPIMAGEASSISTANT_PATH=/tmp/AppImageAssistant.AppImage +APPIMAGEASSISTANT_PATH=$TMPDIR/AppImageAssistant.AppImage download_executable \ "$APPIMAGES_GITHUB_RELEASE_BASE_URL/AppImageAssistant_$APPIMAGES_TAG-$APPIMAGES_ARCHITECTURE.AppImage" \ $APPIMAGEASSISTANT_PATH