From b93fd86092baacfc6b542e08b6c0952a0a54bc1d Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Thu, 20 Apr 2017 12:23:13 -0400 Subject: [PATCH] chore: perform GNU/Linux builds on Debian Jessie docker containers (#1319) We recently hit an issue where Etcher builds produced on Ubuntu relied on a too new glibc version, making them incompatible with GNU/Linux distributions such as Debian Jessie. As a solution, we will start producing builds on Debian Jessie, which ensures that the builds will be compatible with the majority of GNU/Linux versions out there. Signed-off-by: Juan Cruz Viotti --- scripts/build/docker/Dockerfile-i686 | 2 +- scripts/build/docker/Dockerfile-x86_64 | 2 +- scripts/build/docker/compile-template.js | 4 ++-- scripts/build/docker/run-command.sh | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/build/docker/Dockerfile-i686 b/scripts/build/docker/Dockerfile-i686 index 27ecd9ac..bed66e01 100644 --- a/scripts/build/docker/Dockerfile-i686 +++ b/scripts/build/docker/Dockerfile-i686 @@ -1,4 +1,4 @@ -FROM toopher/ubuntu-i386:14.04 +FROM 32bit/debian:jessie # Install dependencies RUN apt-get update && apt-get install -y \ diff --git a/scripts/build/docker/Dockerfile-x86_64 b/scripts/build/docker/Dockerfile-x86_64 index 53ac8a85..1c61a165 100644 --- a/scripts/build/docker/Dockerfile-x86_64 +++ b/scripts/build/docker/Dockerfile-x86_64 @@ -1,4 +1,4 @@ -FROM ubuntu:14.04 +FROM debian:jessie # Install dependencies RUN apt-get update && apt-get install -y \ diff --git a/scripts/build/docker/compile-template.js b/scripts/build/docker/compile-template.js index 1dbb4596..ec2dd83e 100644 --- a/scripts/build/docker/compile-template.js +++ b/scripts/build/docker/compile-template.js @@ -31,11 +31,11 @@ const template = fs.readFileSync(path.join(currentDirectory, 'Dockerfile.templat _.each([ { architecture: 'i686', - image: 'toopher/ubuntu-i386:14.04' + image: '32bit/debian:jessie' }, { architecture: 'x86_64', - image: 'ubuntu:14.04' + image: 'debian:jessie' } ], (options) => { const result = _.template(template)(options); diff --git a/scripts/build/docker/run-command.sh b/scripts/build/docker/run-command.sh index 93db599f..c527501b 100755 --- a/scripts/build/docker/run-command.sh +++ b/scripts/build/docker/run-command.sh @@ -89,6 +89,7 @@ done # The `-t` and TERM setup is needed to display coloured output. docker run -t \ --env "TERM=xterm-256color" \ + --env "TARGET_ARCH=$ARGV_ARCHITECTURE" \ ${DOCKER_ENVVARS[@]+"${DOCKER_ENVVARS[@]}"} \ --cap-add SYS_ADMIN \ --device /dev/fuse:/dev/fuse:mrw \