From bd009a75b0fe9b5bdeeb951e301a9ecf38d43e99 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Wed, 2 Mar 2016 12:28:42 -0400 Subject: [PATCH] Expose shell.openExternal in NavigationController `.open()` was previously exposed in the `AppController`, however after the router refactoring, this controller is no longer instantiated on the footer, and therefore the links that live there stopped working. --- lib/browser/app.js | 3 +-- lib/index.html | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/browser/app.js b/lib/browser/app.js index 42f60ecd..897345c2 100644 --- a/lib/browser/app.js +++ b/lib/browser/app.js @@ -195,8 +195,6 @@ app.controller('AppController', function( }); }; - - this.open = shell.openExternal; }); app.controller('SettingsController', function(SettingsService) { @@ -205,6 +203,7 @@ app.controller('SettingsController', function(SettingsService) { app.controller('NavigationController', function($state) { this.isState = $state.is; + this.open = shell.openExternal; }); app.controller('FinishController', function($state, SelectionStateService, SettingsService) { diff --git a/lib/index.html b/lib/index.html index 63ad39fe..9c538e21 100644 --- a/lib/index.html +++ b/lib/index.html @@ -37,16 +37,16 @@
-