jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-23 19:26:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent dialog.showErrorBox() throwing if wrong parameters (#274)

Browse Source 
If the function lacks a message or a title, the following error is
thrown:

    Error: Could not call remote function ``.
    Check that the function signature is correct.
    Underlying error: Error processing argument at index 0,
    conversion failure from undefined

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-04-10 23:11:29 -04:00
parent 5ccc6b6aa4
commit c2265c6561
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/src/dialog.js
View File

@ -82,6 +82,7 @@ exports.selectImage = function() {
* dialog.showError(new Error('Foo Bar'));
*/
exports.showError = function(error) {
electron.dialog.showErrorBox(error.message, error.stack || '');
error = error || {};
electron.dialog.showErrorBox(error.message || 'An error ocurred!', error.stack || '');
throw error;
};