jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-23 19:26:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead code in settings modal

Browse Source 
Change-type: patch
This commit is contained in:
Alexis Svinartchouk 2020-12-10 14:05:08 +01:00
parent 409b78fc21
commit c32e485f27
1 changed files with 11 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
lib/gui/app/components/settings/settings.tsx
View File

@ -31,15 +31,10 @@ const platform = os.platform();
interface Setting { interface Setting {
name: string; name: string;
label: string | JSX.Element; label: string | JSX.Element;
options?: {
description: string;
confirmLabel: string;
};
hide?: boolean;
} }
async function getSettingsList(): Promise<Setting[]> { async function getSettingsList(): Promise<Setting[]> {
return [ const list: Setting[] = [
{ {
name: 'errorReporting', name: 'errorReporting',
label: 'Anonymously report errors and usage statistics to balena.io', label: 'Anonymously report errors and usage statistics to balena.io',
@ -54,12 +49,14 @@ async function getSettingsList(): Promise<Setting[]> {
*/ */
label: `${platform === 'win32' ? 'Eject' : 'Auto-unmount'} on success`, label: `${platform === 'win32' ? 'Eject' : 'Auto-unmount'} on success`,
}, },
{ ];
if (!['rpm', 'deb'].includes(packageType)) {
list.push({
name: 'updatesEnabled', name: 'updatesEnabled',
label: 'Auto-updates enabled', label: 'Auto-updates enabled',
hide: ['rpm', 'deb'].includes(packageType), });
}, }
]; return list;
} }
interface SettingsModalProps { interface SettingsModalProps {
@ -86,25 +83,14 @@ export function SettingsModal({ toggleModal }: SettingsModalProps) {
})(); })();
}); });
const toggleSetting = async ( const toggleSetting = async (setting: string) => {
setting: string,
options?: Setting['options'],
) => {
const value = currentSettings[setting]; const value = currentSettings[setting];
const dangerous = options !== undefined; analytics.logEvent('Toggle setting', { setting, value });
analytics.logEvent('Toggle setting', {
setting,
value,
dangerous,
});
await settings.set(setting, !value); await settings.set(setting, !value);
setCurrentSettings({ setCurrentSettings({
...currentSettings, ...currentSettings,
[setting]: !value, [setting]: !value,
}); });
return;
}; };
return ( return (
@ -118,14 +104,14 @@ export function SettingsModal({ toggleModal }: SettingsModalProps) {
> >
<Flex flexDirection="column"> <Flex flexDirection="column">
{settingsList.map((setting: Setting, i: number) => { {settingsList.map((setting: Setting, i: number) => {
return setting.hide ? null : ( return (
<Flex key={setting.name} mb={14}> <Flex key={setting.name} mb={14}>
<Checkbox <Checkbox
toggle toggle
tabIndex={6 + i} tabIndex={6 + i}
label={setting.label} label={setting.label}
checked={currentSettings[setting.name]} checked={currentSettings[setting.name]}
onChange={() => toggleSetting(setting.name, setting.options)} onChange={() => toggleSetting(setting.name)}
/> />
</Flex> </Flex>
); );