jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-18 16:56:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): show a friendly message when the drive is unplugged half-way through (#1301)

Browse Source 
This commit shows a user friendly message when Etcher loses access to
the drive while flashing/validating, and prevents the cryptic errors
from getting to Sentry.

See: https://github.com/resin-io-modules/etcher-image-write/pull/96
Change-Type: minor
Changelog-Entry: Show a user friendly message when the drive is unplugged half-way through.
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2017-04-14 14:24:06 -04:00 committed by GitHub
parent e66d805672
commit c5a9a1fca4
4 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/gui/pages/main/controllers/flash.js
View File

@ -87,6 +87,12 @@ module.exports = function(
image, image,
drive drive
}); });
} else if (error.code === 'EUNPLUGGED') {
FlashErrorModalService.show(messages.error.driveUnplugged());
AnalyticsService.logEvent('Drive unplugged', {
image,
drive
});
} else if (error.code === 'ENOSPC') { } else if (error.code === 'ENOSPC') {
FlashErrorModalService.show(messages.error.notEnoughSpaceInDrive()); FlashErrorModalService.show(messages.error.notEnoughSpaceInDrive());
AnalyticsService.logEvent('Out of space', { AnalyticsService.logEvent('Out of space', {

8
lib/shared/messages.js
View File

@ -86,7 +86,13 @@ module.exports = {
elevationRequired: _.template('This should should be run with root/administrator permissions.'), elevationRequired: _.template('This should should be run with root/administrator permissions.'),
flashFailure: _.template('Looks like your flash has failed!') flashFailure: _.template('Looks like your flash has failed!'),
driveUnplugged: _.template([
'Looks like Etcher lost access to the drive.',
'Did it get unplugged accidentally?',
'\n\nSometimes this error is caused by faulty readers that don\'t provide stable access to the drive.'
].join(' '))
} }

12
npm-shrinkwrap.json generated
View File

@ -486,9 +486,9 @@
"resolved": "https://registry.npmjs.org/bluebird-retry/-/bluebird-retry-0.10.1.tgz" "resolved": "https://registry.npmjs.org/bluebird-retry/-/bluebird-retry-0.10.1.tgz"
}, },
"bmapflash": { "bmapflash": {
"version": "1.2.0", "version": "1.2.1",
"from": "bmapflash@>=1.2.0 <2.0.0", "from": "bmapflash@>=1.2.1 <2.0.0",
"resolved": "https://registry.npmjs.org/bmapflash/-/bmapflash-1.2.0.tgz", "resolved": "https://registry.npmjs.org/bmapflash/-/bmapflash-1.2.1.tgz",
"dependencies": { "dependencies": {
"lodash": { "lodash": {
"version": "4.17.4", "version": "4.17.4",
@ -2193,9 +2193,9 @@
"dev": true "dev": true
}, },
"etcher-image-write": { "etcher-image-write": {
"version": "9.0.2", "version": "9.1.0",
"from": "etcher-image-write@9.0.2", "from": "etcher-image-write@9.1.0",
"resolved": "https://registry.npmjs.org/etcher-image-write/-/etcher-image-write-9.0.2.tgz", "resolved": "https://registry.npmjs.org/etcher-image-write/-/etcher-image-write-9.1.0.tgz",
"dependencies": { "dependencies": {
"bluebird": { "bluebird": {
"version": "3.5.0", "version": "3.5.0",

2
package.json
View File

@ -74,7 +74,7 @@
"command-join": "^2.0.0", "command-join": "^2.0.0",
"drivelist": "^5.0.16", "drivelist": "^5.0.16",
"electron-is-running-in-asar": "^1.0.0", "electron-is-running-in-asar": "^1.0.0",
"etcher-image-write": "^9.0.2", "etcher-image-write": "^9.1.0",
"etcher-latest-version": "^1.0.0", "etcher-latest-version": "^1.0.0",
"file-type": "^4.1.0", "file-type": "^4.1.0",
"flexboxgrid": "^6.3.0", "flexboxgrid": "^6.3.0",