refactor(GUI): resolve undefined on modal keyboard bindings (#879)

Currently we resolve `false`, which might not mean very much to some
modal use cases. `undefined` is a much more generic falsy value.

Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-11-18 15:23:10 +00:00 committed by GitHub
parent e85906d50d
commit ca4d05ced0

View File

@ -62,7 +62,7 @@ module.exports = function($uibModal, $q) {
// Bootstrap doesn't 'resolve' these but cancels the dialog;
// therefore call 'resolve' here applied to 'false'.
if (error === 'escape key press' || error === 'backdrop click') {
resolve(false);
resolve();
// For some annoying reason, UI Bootstrap Modal rejects
// the result reason if the user clicks on the backdrop