From cb8da11b8924f0ff02ab395883b3f172b7dd2eba Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 25 Mar 2016 10:10:07 -0400 Subject: [PATCH] Add missing package metadata - Legal copyright. - Company name. - File description. - Original filename. - Product name. - Internal name. --- Makefile | 16 ++++++++++++++++ package.json | 1 + 2 files changed, 17 insertions(+) diff --git a/Makefile b/Makefile index 3d04ea1b..9b7bc9b5 100644 --- a/Makefile +++ b/Makefile @@ -4,6 +4,9 @@ ELECTRON_IGNORE=$(shell node -e "console.log(require('./package.json').packageIg ELECTRON_VERSION=0.36.8 ETCHER_VERSION=$(shell node -e "console.log(require('./package.json').version)") APPLICATION_NAME=$(shell node -e "console.log(require('./package.json').displayName)") +APPLICATION_DESCRIPTION=$(shell node -e "console.log(require('./package.json').description)") +APPLICATION_COPYRIGHT=$(shell node -e "console.log(require('./package.json').copyright)") +COMPANY_NAME="Resinio Ltd" SIGN_IDENTITY_OSX="Rulemotion Ltd (66H43P8FRG)" S3_BUCKET="resin-production-downloads" @@ -14,6 +17,7 @@ etcher-release/Etcher-darwin-x64: . --version=$(ELECTRON_VERSION) \ --ignore="$(ELECTRON_IGNORE)" \ --asar \ + --app-copyright="$(APPLICATION_COPYRIGHT)" \ --app-version="$(ETCHER_VERSION)" \ --build-version="$(ETCHER_VERSION)" \ --helper-bundle-id="io.resin.etcher-helper" \ @@ -57,8 +61,14 @@ etcher-release/Etcher-win32-x86: . --ignore="$(ELECTRON_IGNORE)" \ --icon="assets/icon.ico" \ --asar \ + --app-copyright="$(APPLICATION_COPYRIGHT)" \ --app-version="$(ETCHER_VERSION)" \ --build-version="$(ETCHER_VERSION)" \ + --version-string.CompanyName=$(COMPANY_NAME) \ + --version-string.FileDescription="$(APPLICATION_NAME)" \ + --version-string.OriginalFilename=$(notdir $@) \ + --version-string.ProductName="$(APPLICATION_NAME) -- $(APPLICATION_DESCRIPTION)" \ + --version-string.InternalName="$(APPLICATION_NAME)" \ --overwrite \ --out=$(dir $@) mv $(dir $@)Etcher-win32-ia32 $@ @@ -71,8 +81,14 @@ etcher-release/Etcher-win32-x64: . --ignore="$(ELECTRON_IGNORE)" \ --icon="assets/icon.ico" \ --asar \ + --app-copyright="$(APPLICATION_COPYRIGHT)" \ --app-version="$(ETCHER_VERSION)" \ --build-version="$(ETCHER_VERSION)" \ + --version-string.CompanyName=$(COMPANY_NAME) \ + --version-string.FileDescription="$(APPLICATION_NAME)" \ + --version-string.OriginalFilename=$(notdir $@) \ + --version-string.ProductName="$(APPLICATION_NAME) -- $(APPLICATION_DESCRIPTION)" \ + --version-string.InternalName="$(APPLICATION_NAME)" \ --overwrite \ --out=$(dir $@) diff --git a/package.json b/package.json index 7d400bcb..f99998e2 100644 --- a/package.json +++ b/package.json @@ -17,6 +17,7 @@ }, "author": "Juan Cruz Viotti ", "license": "Apache-2.0", + "copyright": "Copyright 2016 Resinio Ltd", "packageIgnore": [ "LICENSE", "Makefile",