jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-14 23:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2557 from balena-io/explicit-safe-webview-events

Browse Source 
Use explicit names for safe-webview events
This commit is contained in:
Lorenzo Alberto Maria Ambrosi 2018-11-28 21:11:10 +01:00 committed by GitHub
commit cf596a88ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/gui/app/components/safe-webview/safe-webview.jsx
View File

@ -194,7 +194,8 @@ class SafeWebview extends react.PureComponent {
if (event.resourceType === 'mainFrame') { if (event.resourceType === 'mainFrame') {
const HTTP_OK = 200 const HTTP_OK = 200
analytics.logEvent(event, { analytics.logEvent('SafeWebview loaded', {
event,
applicationSessionUuid: store.getState().toJS().applicationSessionUuid, applicationSessionUuid: store.getState().toJS().applicationSessionUuid,
flashingWorkflowUuid: store.getState().toJS().flashingWorkflowUuid flashingWorkflowUuid: store.getState().toJS().flashingWorkflowUuid
}) })
@ -250,7 +251,8 @@ class SafeWebview extends react.PureComponent {
if (message.command === 'error') { if (message.command === 'error') {
analytics.logException(message.data) analytics.logException(message.data)
} else { } else {
analytics.logEvent(message.data || message, { analytics.logEvent('SafeWebview console message', {
message,
applicationSessionUuid: store.getState().toJS().applicationSessionUuid, applicationSessionUuid: store.getState().toJS().applicationSessionUuid,
flashingWorkflowUuid: store.getState().toJS().flashingWorkflowUuid flashingWorkflowUuid: store.getState().toJS().flashingWorkflowUuid
}) })