jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 15:27:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix output_package unbound variable in GNU/Linux (#767)

Browse Source 
The `$output_package` variable is defined inside the `package_x$ARCH`
functions, which means that if we run the following commands:

```sh
./scripts/build/linux.sh package x64
./scripts/build/linux.sh appimage x64
```

The `$output_package` variable will not be defined when the script runs
the `appimage` command.

To workaround this issue, we declare a new `$package_directory` variable
inside the `appimage` command clause.

Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-10-24 14:25:37 -04:00 committed by GitHub
parent 1609b8df5b
commit d7d9dc099f
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/build/linux.sh
View File

@ -197,15 +197,19 @@ if [ "$COMMAND" == "debian" ] || [ "$COMMAND" == "all" ]; then
fi
if [ "$COMMAND" == "appimage" ] || [ "$COMMAND" == "all" ]; then
package_directory=etcher-release/Etcher-linux-$ARCH
if [ "$ARCH" == "x86" ]; then
# UPX fails for some reason with some other so libraries
# other than libnode.so in the x86 build
upx -9 $output_package/etcher $output_package/libnode.so
upx -9 $package_directory/etcher $package_directory/libnode.so
fi
if [ "$ARCH" == "x64" ]; then
upx -9 $output_package/etcher $output_package/*.so*
upx -9 $package_directory/etcher $package_directory/*.so*
fi
installer etcher-release/Etcher-linux-$ARCH $ARCH etcher-release/installers
installer $package_directory $ARCH etcher-release/installers
fi