From d9641fc557591ce5c431160b36b59fd116335763 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 1 Jan 2016 17:02:13 -0400 Subject: [PATCH] Rename setProgress to setProgressState It shows the intention more clearly now that the function not only accepts a plain percentage. --- build/browser/app.js | 10 +++++----- lib/browser/modules/image-writer.js | 10 +++++----- tests/browser/modules/image-writer.spec.js | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/build/browser/app.js b/build/browser/app.js index 0b9ceba5..c905a7ea 100644 --- a/build/browser/app.js +++ b/build/browser/app.js @@ -355,7 +355,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { }; /** - * @summary Set progress percentage + * @summary Set progress state * @function * @private * @@ -363,11 +363,11 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { * @param {Number} state.percentage - progress percentage * * @example - * ImageWriterService.setProgress({ + * ImageWriterService.setProgressState({ * percentage: 50 * }); */ - this.setProgress = function(state) { + this.setProgressState = function(state) { // Safely bring the state to the world of Angular $timeout(function() { @@ -386,7 +386,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { * ImageWriterService.reset(); */ this.reset = function() { - self.setProgress({ + self.setProgressState({ percentage: 0 }); }; @@ -475,7 +475,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { self.setBurning(true); - return self.performWrite(image, drive, self.setProgress).finally(function() { + return self.performWrite(image, drive, self.setProgressState).finally(function() { self.setBurning(false); }); }; diff --git a/lib/browser/modules/image-writer.js b/lib/browser/modules/image-writer.js index c96b7be5..f59fc3e3 100644 --- a/lib/browser/modules/image-writer.js +++ b/lib/browser/modules/image-writer.js @@ -47,7 +47,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { }; /** - * @summary Set progress percentage + * @summary Set progress state * @function * @private * @@ -55,11 +55,11 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { * @param {Number} state.percentage - progress percentage * * @example - * ImageWriterService.setProgress({ + * ImageWriterService.setProgressState({ * percentage: 50 * }); */ - this.setProgress = function(state) { + this.setProgressState = function(state) { // Safely bring the state to the world of Angular $timeout(function() { @@ -78,7 +78,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { * ImageWriterService.reset(); */ this.reset = function() { - self.setProgress({ + self.setProgressState({ percentage: 0 }); }; @@ -167,7 +167,7 @@ imageWriter.service('ImageWriterService', function($q, $timeout) { self.setBurning(true); - return self.performWrite(image, drive, self.setProgress).finally(function() { + return self.performWrite(image, drive, self.setProgressState).finally(function() { self.setBurning(false); }); }; diff --git a/tests/browser/modules/image-writer.spec.js b/tests/browser/modules/image-writer.spec.js index abaff962..f8cdc111 100644 --- a/tests/browser/modules/image-writer.spec.js +++ b/tests/browser/modules/image-writer.spec.js @@ -61,10 +61,10 @@ describe('Browser: ImageWriter', function() { }); - describe('.setProgress()', function() { + describe('.setProgressState()', function() { it('should be able to set the progress', function() { - ImageWriterService.setProgress({ + ImageWriterService.setProgressState({ percentage: 50 }); @@ -73,7 +73,7 @@ describe('Browser: ImageWriter', function() { }); it('should floor the percentage', function() { - ImageWriterService.setProgress({ + ImageWriterService.setProgressState({ percentage: 49.9999 }); @@ -86,7 +86,7 @@ describe('Browser: ImageWriter', function() { describe('.reset()', function() { it('should reset progress percentage to 0', function() { - ImageWriterService.setProgress({ + ImageWriterService.setProgressState({ percentage: 50 });