mirror of
https://github.com/balena-io/etcher.git
synced 2025-07-22 18:56:31 +00:00
chore: fix various code-signing Windows issues (#1135)
- Add missing backslash that caused the command to not be interpreted completely - Update `electron-sign-exe.exe` to `electron-sign-exe-win32.exe` in Makefile - Use hyphen options instead of Windows slash style, which confuses bash Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
parent
be001cc266
commit
d9bd509d22
8
Makefile
8
Makefile
@ -242,8 +242,8 @@ ifeq ($(TARGET_PLATFORM),win32)
|
||||
-o $@
|
||||
ifdef CODE_SIGN_CERTIFICATE
|
||||
ifdef CODE_SIGN_CERTIFICATE_PASSWORD
|
||||
./scripts/build/electron-sign-exe.sh -f $@/$(APPLICATION_NAME).exe \
|
||||
-d "$(APPLICATION_NAME) - $(APPLICATION_VERSION)"
|
||||
./scripts/build/electron-sign-exe-win32.sh -f $@/$(APPLICATION_NAME).exe \
|
||||
-d "$(APPLICATION_NAME) - $(APPLICATION_VERSION)" \
|
||||
-c $(CODE_SIGN_CERTIFICATE) \
|
||||
-p $(CODE_SIGN_CERTIFICATE_PASSWORD)
|
||||
endif
|
||||
@ -316,8 +316,8 @@ $(BUILD_OUTPUT_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-win32-$(TAR
|
||||
./scripts/build/electron-installer-nsis-win32.sh -n $(APPLICATION_NAME) -a $< -t $(BUILD_TEMPORARY_DIRECTORY) -o $@
|
||||
ifdef CODE_SIGN_CERTIFICATE
|
||||
ifdef CODE_SIGN_CERTIFICATE_PASSWORD
|
||||
./scripts/build/electron-sign-exe.sh -f $@ \
|
||||
-d "$(APPLICATION_NAME) - $(APPLICATION_VERSION)"
|
||||
./scripts/build/electron-sign-exe-win32.sh -f $@ \
|
||||
-d "$(APPLICATION_NAME) - $(APPLICATION_VERSION)" \
|
||||
-c $(CODE_SIGN_CERTIFICATE) \
|
||||
-p $(CODE_SIGN_CERTIFICATE_PASSWORD)
|
||||
endif
|
||||
|
@ -65,10 +65,10 @@ fi
|
||||
TIMESTAMP_SERVER=http://timestamp.comodoca.com
|
||||
|
||||
signtool sign \
|
||||
/t "$TIMESTAMP_SERVER" \
|
||||
/d "$ARGV_SIGNATURE_DESCRIPTION" \
|
||||
/f "$ARGV_CERTIFICATE_FILE" \
|
||||
/p "$ARGV_CERTIFICATE_PASSWORD" \
|
||||
-t "$TIMESTAMP_SERVER" \
|
||||
-d "$ARGV_SIGNATURE_DESCRIPTION" \
|
||||
-f "$ARGV_CERTIFICATE_FILE" \
|
||||
-p "$ARGV_CERTIFICATE_PASSWORD" \
|
||||
"$ARGV_FILE"
|
||||
|
||||
signtool verify /pa /v "$ARGV_FILE"
|
||||
signtool verify -pa -v "$ARGV_FILE"
|
||||
|
Loading…
x
Reference in New Issue
Block a user