jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 07:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix failing ImageSelectionController tests (#856)

Browse Source 
This was a small issue affected due to the change in order of the
supported extensions in the ImageSelectionController.

Since we want to test that the array contents are equally the same
independently on the order, we sort both sides of the assertion.

This issue was not caught before since `electron-mocha` was reporting
exit code 0 even when there were changes failing, causing the CI
services to incorrectly support success.

See: https://github.com/resin-io/etcher/pull/854
See: https://github.com/resin-io/etcher/pull/806
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-11-09 21:23:30 +02:00 committed by GitHub
parent 5d25ef7dee
commit dae07ad050
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/gui/pages/main.spec.js
View File

@ -1,6 +1,7 @@
'use strict';
const m = require('mochainon');
const _ = require('lodash');
const angular = require('angular');
require('angular-mocks');
@ -143,7 +144,7 @@ describe('Browser: MainPage', function() {
});
const extensions = controller.mainSupportedExtensions.concat(controller.extraSupportedExtensions);
m.chai.expect(extensions).to.deep.equal(SupportedFormatsModel.getAllExtensions());
m.chai.expect(_.sortBy(extensions)).to.deep.equal(_.sortBy(SupportedFormatsModel.getAllExtensions()));
});
});