jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-16 15:56:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use full path to wmic as some systems don't have it in their PATH

Browse Source 
Changelog-entry: (Windows): Use full path to wmic as some systems don't have it in their PATH
Change-type: patch
This commit is contained in:
Alexis Svinartchouk 2019-04-02 14:45:29 +02:00
parent 0695cfb3c0
commit db771bc2cc
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/gui/app/os/windows-network-drives.js
View File

@ -19,6 +19,8 @@
const cp = require('child_process')
const _ = require('lodash')
const os = require('os')
const path = require('path')
const process = require('process')
/**
* @summary Promisified child_process.execFile
@ -63,7 +65,7 @@ const execFileAsync = async (file, args, options) => {
*/
const getWindowsNetworkDrives = async () => {
const result = await execFileAsync(
'wmic',
path.join(process.env.SystemRoot, 'System32', 'Wbem', 'wmic'),
[ 'path', 'Win32_LogicalDisk', 'Where', 'DriveType="4"', 'get', 'DeviceID,ProviderName' ],
{ windowsHide: true, windowsVerbatimArguments: true }
)

4
tests/gui/os/windows-network-drives.spec.js
View File

@ -20,6 +20,7 @@ const { readFile } = require('fs')
const os = require('os')
const cp = require('child_process')
const m = require('mochainon')
const { env } = require('process')
const { promisify } = require('util')
const { replaceWindowsNetworkDriveLetter } = require('../../../lib/gui/app/os/windows-network-drives')
@ -33,6 +34,8 @@ describe('Network drives on Windows', () => {
const wmicOutput = await readFileAsync('tests/data/wmic-output.txt', { encoding: 'ucs2' })
this.execFileStub = m.sinon.stub(cp, 'execFile')
this.execFileStub.callsArgWith(3, null, wmicOutput)
this.oldSystemRoot = env.SystemRoot
env.SystemRoot = 'C:\\Windows'
})
it('should parse network drive mapping on Windows', async () => {
@ -43,5 +46,6 @@ describe('Network drives on Windows', () => {
after(() => {
this.osPlatformStub.restore()
this.execFileStub.restore()
env.SystemRoot = this.oldSystemRoot
})
})