jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 07:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: throw if attempting to select a locked drive (#512)

Browse Source 
We shouldn't allow a write-protected drive from being selected, since
users will get confusing `EPERM` errors later on.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-06-23 09:26:23 -04:00 committed by GitHub
parent a93c28ab20
commit e16139af03
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/gui/models/store.js
View File

@ -96,6 +96,10 @@ module.exports = redux.createStore(function(state, action) {
throw new Error(`Invalid drive protected state: ${action.data.protected}`);
}
if (action.data.protected) {
throw new Error('The drive is write-protected');
}
// TODO: Reuse from SelectionStateModel.isDriveLargeEnough()
if (state.getIn([ 'selection', 'image', 'size' ], 0) > action.data.size) {
throw new Error('The drive is not large enough');

11
tests/gui/models/selection-state.spec.js
View File

@ -199,6 +199,17 @@ describe('Browser: SelectionState', function() {
});
});
it('should throw if drive is write protected', function() {
m.chai.expect(function() {
SelectionStateModel.setDrive({
device: '/dev/disk1',
name: 'USB Drive',
size: 999999999,
protected: true
});
}).to.throw('The drive is write-protected');
});
it('should throw if no device', function() {
m.chai.expect(function() {
SelectionStateModel.setDrive({