Remove "Validate write on success" setting

Validation is always enabled, press the "skip" button to skip it.

Changelog-entry: Remove "Validate write on success" setting. Validation is always enabled, press the "skip" button to skip it.
Change-type: patch

lib/gui/app/components/settings/settings.tsx

@@ -54,10 +54,6 @@ async function getSettingsList(): Promise<Setting[]> {
 			 */
 			label: `${platform === 'win32' ? 'Eject' : 'Auto-unmount'} on success`,
 		},
-		{
-			name: 'validateWriteOnSuccess',
-			label: 'Validate write on success',
-		},
 		{
 			name: 'updatesEnabled',
 			label: 'Auto-updates enabled',

lib/gui/app/models/settings.ts

@@ -78,7 +78,6 @@ export async function writeConfigFile(
 const DEFAULT_SETTINGS: _.Dictionary<any> = {
 	errorReporting: true,
 	unmountOnSuccess: true,
-	validateWriteOnSuccess: true,
 	updatesEnabled: !_.includes(['rpm', 'deb'], packageJSON.packageType),
 	desktopNotifications: true,
 	autoBlockmapping: true,

lib/gui/app/modules/image-writer.ts

@@ -145,7 +145,6 @@ async function performWrite(
 	ipc.serve();
 	const {
 		unmountOnSuccess,
-		validateWriteOnSuccess,
 		autoBlockmapping,
 		decompressFirst,
 	} = await settings.getAll();
@@ -168,7 +167,6 @@ async function performWrite(
 			uuid: flashState.getFlashUuid(),
 			flashInstanceUuid: flashState.getFlashUuid(),
 			unmountOnSuccess,
-			validateWriteOnSuccess,
 		};
 
 		ipc.server.on('fail', ({ device, error }) => {
@@ -202,7 +200,6 @@ async function performWrite(
 				image,
 				destinations: drives,
 				SourceType: image.SourceType.name,
-				validateWriteOnSuccess,
 				autoBlockmapping,
 				unmountOnSuccess,
 				decompressFirst,
@@ -284,7 +281,6 @@ export async function flash(
 		status: 'started',
 		flashInstanceUuid: flashState.getFlashUuid(),
 		unmountOnSuccess: await settings.get('unmountOnSuccess'),
-		validateWriteOnSuccess: await settings.get('validateWriteOnSuccess'),
 	};
 
 	analytics.logEvent('Flash', analyticsData);
@@ -340,7 +336,6 @@ export async function cancel(type: string) {
 		uuid: flashState.getFlashUuid(),
 		flashInstanceUuid: flashState.getFlashUuid(),
 		unmountOnSuccess: await settings.get('unmountOnSuccess'),
-		validateWriteOnSuccess: await settings.get('validateWriteOnSuccess'),
 		status,
 	};
 	analytics.logEvent('Cancel', analyticsData);

lib/gui/modules/child-writer.ts

@@ -161,7 +161,6 @@ interface WriteOptions {
 	image: SourceMetadata;
 	destinations: DrivelistDrive[];
 	unmountOnSuccess: boolean;
-	validateWriteOnSuccess: boolean;
 	autoBlockmapping: boolean;
 	decompressFirst: boolean;
 	SourceType: string;
@@ -255,7 +254,6 @@ ipc.connectTo(IPC_SERVER_ID, () => {
 		log(`Image: ${imagePath}`);
 		log(`Devices: ${destinations.join(', ')}`);
 		log(`Umount on success: ${options.unmountOnSuccess}`);
-		log(`Validate on success: ${options.validateWriteOnSuccess}`);
 		log(`Auto blockmapping: ${options.autoBlockmapping}`);
 		log(`Decompress first: ${options.decompressFirst}`);
 		const dests = options.destinations.map((destination) => {
@@ -286,7 +284,7 @@ ipc.connectTo(IPC_SERVER_ID, () => {
 			const results = await writeAndValidate({
 				source,
 				destinations: dests,
-				verify: options.validateWriteOnSuccess,
+				verify: true,
 				autoBlockmapping: options.autoBlockmapping,
 				decompressFirst: options.decompressFirst,
 				onProgress,

tests/gui/modules/progress-status.spec.ts

@@ -32,7 +32,6 @@ describe('Browser: progressStatus', function () {
 			};
 
 			settings.set('unmountOnSuccess', true);
-			settings.set('validateWriteOnSuccess', true);
 		});
 
 		it('should report 0% if percentage == 0 but speed != 0', function () {
@@ -105,25 +104,16 @@ describe('Browser: progressStatus', function () {
 			);
 		});
 
-		it('should handle percentage == 100, flashing, unmountOnSuccess, validateWriteOnSuccess', function () {
+		it('should handle percentage == 100, flashing, unmountOnSuccess', function () {
 			this.state.percentage = 100;
 			expect(progressStatus.titleFromFlashState(this.state)).to.equal(
 				'Finishing...',
 			);
 		});
 
-		it('should handle percentage == 100, flashing, unmountOnSuccess, !validateWriteOnSuccess', function () {
+		it('should handle percentage == 100, flashing, !unmountOnSuccess', function () {
-			this.state.percentage = 100;
-			settings.set('validateWriteOnSuccess', false);
-			expect(progressStatus.titleFromFlashState(this.state)).to.equal(
-				'Finishing...',
-			);
-		});
-
-		it('should handle percentage == 100, flashing, !unmountOnSuccess, !validateWriteOnSuccess', function () {
 			this.state.percentage = 100;
 			settings.set('unmountOnSuccess', false);
-			settings.set('validateWriteOnSuccess', false);
 			expect(progressStatus.titleFromFlashState(this.state)).to.equal(
 				'Finishing...',
 			);