From e737a1edbd171de839154cfe1f2817b955880c9c Mon Sep 17 00:00:00 2001 From: Alexis Svinartchouk Date: Wed, 8 Jan 2020 15:06:51 +0100 Subject: [PATCH] Convert exit-codes.js to typescript Change-type: patch --- lib/gui/app/app.js | 1 + lib/gui/etcher.js | 1 + lib/gui/modules/child-writer.js | 1 + lib/shared/exit-codes.js | 66 --------------------------------- lib/shared/exit-codes.ts | 20 ++++++++++ tests/spectron/runner.spec.js | 1 + 6 files changed, 24 insertions(+), 66 deletions(-) delete mode 100644 lib/shared/exit-codes.js create mode 100644 lib/shared/exit-codes.ts diff --git a/lib/gui/app/app.js b/lib/gui/app/app.js index dc514d93..fc418695 100644 --- a/lib/gui/app/app.js +++ b/lib/gui/app/app.js @@ -25,6 +25,7 @@ const sdk = require('etcher-sdk') const _ = require('lodash') const uuidV4 = require('uuid/v4') +// eslint-disable-next-line node/no-missing-require const EXIT_CODES = require('../../shared/exit-codes') const messages = require('../../shared/messages') const store = require('./models/store') diff --git a/lib/gui/etcher.js b/lib/gui/etcher.js index 7907bfd8..ad92a5d4 100644 --- a/lib/gui/etcher.js +++ b/lib/gui/etcher.js @@ -22,6 +22,7 @@ const _ = require('lodash') const { autoUpdater } = require('electron-updater') const Bluebird = require('bluebird') const semver = require('semver') +// eslint-disable-next-line node/no-missing-require const EXIT_CODES = require('../shared/exit-codes') // eslint-disable-next-line node/no-missing-require const { buildWindowMenu } = require('./menu') diff --git a/lib/gui/modules/child-writer.js b/lib/gui/modules/child-writer.js index a60e0358..76811582 100644 --- a/lib/gui/modules/child-writer.js +++ b/lib/gui/modules/child-writer.js @@ -20,6 +20,7 @@ const Bluebird = require('bluebird') const _ = require('lodash') const ipc = require('node-ipc') const sdk = require('etcher-sdk') +// eslint-disable-next-line node/no-missing-require const EXIT_CODES = require('../../shared/exit-codes') const errors = require('../../shared/errors') diff --git a/lib/shared/exit-codes.js b/lib/shared/exit-codes.js deleted file mode 100644 index 8637c869..00000000 --- a/lib/shared/exit-codes.js +++ /dev/null @@ -1,66 +0,0 @@ -/* - * Copyright 2016 balena.io - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -'use strict' - -/** - * @summary Etcher exit codes - * @namespace EXIT_CODES - * @public - */ -module.exports = { - - /** - * @property {Number} SUCCESS - * @memberof EXIT_CODES - * - * @description - * This exit code is used to represent a successful exit - * status, with no problems on the way. - */ - SUCCESS: 0, - - /** - * @property {Number} GENERAL_ERROR - * @memberof EXIT_CODES - * - * @description - * This exit code is used to represent a general error - * situation. If the reasons of the error is not - * documented as a specialised error code, this one - * should be used. - */ - GENERAL_ERROR: 1, - - /** - * @property {Number} VALIDATION_ERROR - * @memberof EXIT_CODES - * - * @description - * This exit code is used to represent a validation error. - */ - VALIDATION_ERROR: 2, - - /** - * @property {Number} CANCELLED - * @memberof EXIT_CODES - * - * @description - * This exit code is used to represent a cancelled write process. - */ - CANCELLED: 3 - -} diff --git a/lib/shared/exit-codes.ts b/lib/shared/exit-codes.ts new file mode 100644 index 00000000..d5688bf8 --- /dev/null +++ b/lib/shared/exit-codes.ts @@ -0,0 +1,20 @@ +/* + * Copyright 2016 balena.io + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export const SUCCESS = 0; +export const GENERAL_ERROR = 1; +export const VALIDATION_ERROR = 2; +export const CANCELLED = 3; diff --git a/tests/spectron/runner.spec.js b/tests/spectron/runner.spec.js index a657fd9a..dd9a15c5 100644 --- a/tests/spectron/runner.spec.js +++ b/tests/spectron/runner.spec.js @@ -19,6 +19,7 @@ const Bluebird = require('bluebird') const spectron = require('spectron') const m = require('mochainon') +// eslint-disable-next-line node/no-missing-require const EXIT_CODES = require('../../lib/shared/exit-codes') const entrypoint = process.env.ETCHER_SPECTRON_ENTRYPOINT