jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-18 00:36:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

minifix: replace succeeded with successful in messages (#2273)

Browse Source 
Change-Type: patch
This commit is contained in:
Benedict Aas 2018-04-25 15:08:46 +01:00 committed by GitHub
parent 8f969374c7
commit ee831da52d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/shared/messages.js
View File

@ -52,7 +52,7 @@ module.exports = {
*/ */
info: { info: {
flashComplete: (imageBasename, [ drive ], { failed, succeeded: successful }) => { flashComplete: (imageBasename, [ drive ], { failed, successful }) => {
/* eslint-disable no-magic-numbers */ /* eslint-disable no-magic-numbers */
const targets = [] const targets = []
if (failed + successful === 1) { if (failed + successful === 1) {

2
tests/gui/modules/progress-status.spec.js
View File

@ -10,7 +10,7 @@ describe('Browser: progressStatus', function () {
this.state = { this.state = {
flashing: 1, flashing: 1,
verifying: 0, verifying: 0,
succeeded: 0, successful: 0,
failed: 0, failed: 0,
percentage: 0, percentage: 0,
eta: 15, eta: 15,

2
tests/gui/os/window-progress.spec.js
View File

@ -34,7 +34,7 @@ describe('Browser: WindowProgress', function () {
this.state = { this.state = {
flashing: 1, flashing: 1,
verifying: 0, verifying: 0,
succeeded: 0, successful: 0,
failed: 0, failed: 0,
percentage: 85, percentage: 85,
speed: 100 speed: 100

2
tests/gui/pages/main.spec.js
View File

@ -243,7 +243,7 @@ describe('Browser: MainPage', function () {
flashState.setProgressState({ flashState.setProgressState({
flashing: 1, flashing: 1,
verifying: 0, verifying: 0,
succeeded: 0, successful: 0,
failed: 0, failed: 0,
percentage: 85, percentage: 85,
eta: 15, eta: 15,

BIN
tests/image-stream/data/dmg/raspberrypi-raw.dmg
View File

Binary file not shown.

8
tests/shared/messages.spec.js
View File

@ -49,7 +49,7 @@ describe('Shared: Messages', function () {
it('should use singular when there are single results', function () { it('should use singular when there are single results', function () {
const msg = messages.info.flashComplete('image.img', this.drives, { const msg = messages.info.flashComplete('image.img', this.drives, {
failed: 1, failed: 1,
succeeded: 1 successful: 1
}) })
m.chai.expect(msg).to.equal('image.img was successfully flashed to 1 target and failed to be flashed to 1 target') m.chai.expect(msg).to.equal('image.img was successfully flashed to 1 target and failed to be flashed to 1 target')
@ -58,7 +58,7 @@ describe('Shared: Messages', function () {
it('should use plural when there are multiple results', function () { it('should use plural when there are multiple results', function () {
const msg = messages.info.flashComplete('image.img', this.drives, { const msg = messages.info.flashComplete('image.img', this.drives, {
failed: 2, failed: 2,
succeeded: 2 successful: 2
}) })
m.chai.expect(msg).to.equal('image.img was successfully flashed to 2 targets and failed to be flashed to 2 targets') m.chai.expect(msg).to.equal('image.img was successfully flashed to 2 targets and failed to be flashed to 2 targets')
@ -67,7 +67,7 @@ describe('Shared: Messages', function () {
it('should not contain failed target part when there are none', function () { it('should not contain failed target part when there are none', function () {
const msg = messages.info.flashComplete('image.img', this.drives, { const msg = messages.info.flashComplete('image.img', this.drives, {
failed: 0, failed: 0,
succeeded: 2 successful: 2
}) })
m.chai.expect(msg).to.equal('image.img was successfully flashed to 2 targets') m.chai.expect(msg).to.equal('image.img was successfully flashed to 2 targets')
@ -76,7 +76,7 @@ describe('Shared: Messages', function () {
it('should show drive name and description when only target', function () { it('should show drive name and description when only target', function () {
const msg = messages.info.flashComplete('image.img', this.drives, { const msg = messages.info.flashComplete('image.img', this.drives, {
failed: 0, failed: 0,
succeeded: 1 successful: 1
}) })
m.chai.expect(msg).to.equal('image.img was successfully flashed to My Drive (/dev/disk1)') m.chai.expect(msg).to.equal('image.img was successfully flashed to My Drive (/dev/disk1)')