From f0020d9fcf74da3b315e2aef8e47e47558ee85a5 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 27 Jan 2017 18:01:56 -0400 Subject: [PATCH] chore: fix undefined TEMPORARY_DIRECTORY variable (#1059) This variable was renamed to `BUILD_TEMPORARY_DIRECTORY`, but the Makefile silently expands this to nothing and carries on with the build. Now that the variable is expanded correctly, we must add it as an order-only prerequisite so it gets created. Signed-off-by: Juan Cruz Viotti --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 424ad438..0c7b11ae 100644 --- a/Makefile +++ b/Makefile @@ -211,7 +211,7 @@ $(BUILD_DIRECTORY)/electron-$(ELECTRON_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH): \ $(BUILD_DIRECTORY)/electron-$(TARGET_PLATFORM)-$(APPLICATION_VERSION)-$(TARGET_ARCH)-app.asar \ $(BUILD_DIRECTORY)/electron-$(ELECTRON_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH).zip \ - | $(BUILD_DIRECTORY) + | $(BUILD_DIRECTORY) $(BUILD_TEMPORARY_DIRECTORY) ifeq ($(TARGET_PLATFORM),darwin) ./scripts/build/electron-configure-package-darwin.sh -p $(word 2,$^) -a $< \ -n "$(APPLICATION_NAME)" \ @@ -238,7 +238,7 @@ ifeq ($(TARGET_PLATFORM),win32) -c "$(APPLICATION_COPYRIGHT)" \ -m "$(COMPANY_NAME)" \ -i assets/icon.ico \ - -w $(TEMPORARY_DIRECTORY) \ + -w $(BUILD_TEMPORARY_DIRECTORY) \ -o $@ ifdef CODE_SIGN_CERTIFICATE ifdef CODE_SIGN_CERTIFICATE_PASSWORD