jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 07:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

minifix(GUI): keep settings checkboxes unchecked until user confirms (#821)

Browse Source 
There are some settings, such as "unsafe mode", that prompt the user for
confirmation before actually confirming the setting. In these cases,
when the user attempts to check the checkbox, the checkbox remains
checked unless the user rejects the confirmation dialog, in which case
the checkbox value is reverted.

In order to provide a better UX, we now keep the checkbox unchecked
until the user confirms.

See: https://github.com/resin-io/etcher/issues/729
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-11-02 18:25:29 -04:00 committed by GitHub
parent 8b47c3f017
commit f16e176b0f
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/gui/pages/settings/controllers/settings.js
View File

@ -70,9 +70,14 @@ module.exports = function(WarningModalService, SettingsModel) {
return this.refreshSettings();
}
// Keep the checkbox unchecked until the user confirms
this.currentData[name] = false;
WarningModalService.display(message).then((userAccepted) => {
this.model.set(name, Boolean(userAccepted));
this.refreshSettings();
if (userAccepted) {
this.model.set(name, true);
this.refreshSettings();
}
});
};