jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-24 19:56:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return to avoid any further code execution after an elevation error

Browse Source 
Turns out that even by using `process.exit(1)`, the electron main
process doesn't exit instantly, but continues executing code.

This causes electron to throw on `electron.globalShortcut` because this
functionality is not available given that we didn't create a renderer
view.

Fixes: https://github.com/resin-io/etcher/issues/215
This commit is contained in:
Juan Cruz Viotti 2016-03-25 09:41:30 -04:00
parent 34147fb4cb
commit f530dfcc3c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/etcher.js
View File

@ -32,7 +32,7 @@ electron.app.on('ready', function() {
if (error) { if (error) {
electron.dialog.showErrorBox('Elevation Error', error.message); electron.dialog.showErrorBox('Elevation Error', error.message);
process.exit(1); return process.exit(1);
} }
mainWindow = new electron.BrowserWindow({ mainWindow = new electron.BrowserWindow({