From f67f25bcdc6a33a6f7006c5c0a20bb5d21cf16d8 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Mon, 28 Aug 2017 11:27:01 -0400 Subject: [PATCH] chore: don't zip AppImages (#1703) See: https://github.com/AppImage/AppImageKit/wiki/Creating-AppImages#common-mistake See: https://github.com/resin-io/etcher/pull/772 Signed-off-by: Juan Cruz Viotti --- Makefile | 9 ++------- README.md | 4 ++++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index c5f78267..9acf0447 100644 --- a/Makefile +++ b/Makefile @@ -346,11 +346,6 @@ $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET -w $(BUILD_TEMPORARY_DIRECTORY) \ -o $@ -$(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip: \ - $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage \ - | $(BUILD_DIRECTORY) - ./scripts/build/zip-file.sh -f $< -s $(PLATFORM) -o $@ - $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-Portable-$(APPLICATION_VERSION)-$(TARGET_ARCH).exe: \ | $(BUILD_DIRECTORY) TARGET_ARCH=$(TARGET_ARCH) $(NPX) build --win portable $(ELECTRON_BUILDER_OPTIONS) \ @@ -413,7 +408,7 @@ PUBLISH_AWS_S3 += \ endif ifeq ($(PLATFORM),linux) -electron-installer-appimage: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip +electron-installer-appimage: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage electron-installer-debian: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)_$(APPLICATION_VERSION_DEBIAN)_$(TARGET_ARCH_DEBIAN).deb electron-installer-redhat: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)-$(APPLICATION_VERSION_REDHAT).$(TARGET_ARCH_REDHAT).rpm cli-installer-tar-gz: $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH).tar.gz @@ -423,7 +418,7 @@ TARGETS += \ electron-installer-redhat \ cli-installer-tar-gz PUBLISH_AWS_S3 += \ - $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip \ + $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage \ $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH).tar.gz PUBLISH_BINTRAY_DEBIAN += \ $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)_$(APPLICATION_VERSION_DEBIAN)_$(TARGET_ARCH_DEBIAN).deb diff --git a/README.md b/README.md index 65c729e0..cb49ae9f 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,10 @@ Installers Refer to the [downloads page][etcher] for the latest pre-made installers for all supported operating systems. +#### AppImage + +Set execution permissions on the `.AppImage` file and double-click it. + #### Debian and Ubuntu based Package Repository (GNU/Linux x86/x64) 1. Add Etcher debian repository: