From f889a0862ac29654d777a5e6538f300217fae4b9 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Mon, 5 Dec 2016 22:56:34 -0400 Subject: [PATCH] chore: don't include *.dll files inside the asar archive (#944) This change is needed to make `electron-create-asar.sh` output valid asar packages on Windows (Msys). Signed-off-by: Juan Cruz Viotti --- scripts/unix/electron-create-asar.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/unix/electron-create-asar.sh b/scripts/unix/electron-create-asar.sh index 0635167e..8a493e8b 100755 --- a/scripts/unix/electron-create-asar.sh +++ b/scripts/unix/electron-create-asar.sh @@ -54,4 +54,9 @@ if [ -z "$ARGV_DIRECTORY" ] || [ -z "$ARGV_OUTPUT" ]; then fi mkdir -p $(dirname "$ARGV_OUTPUT") -asar pack "$ARGV_DIRECTORY" "$ARGV_OUTPUT" --unpack *.node + +# Omit `*.dll` and `*.node` files from the +# asar package, otherwise `process.dlopen` and +# `module.require` can't load them correctly. +asar pack "$ARGV_DIRECTORY" "$ARGV_OUTPUT" \ + --unpack "{*.dll,*.node}"