Improve UX when re-selecting a single available drive (#313)

Currently, if you have only one connected drive, Etcher will auto-select
it. One the single drive is auto-selected, if you attempt to change your
drive selection by clicking on the "Change" link button, the
re-selection is undone, and redone in a matter of milliseconds, making
it very difficult to get the drive selector modal to open.

A simple solution to this problem is making "Change" links trigger the
reselection action (e.g: opening modals, dialogs, etc) instead of simply
undoing the selection.

Fixes: https://github.com/resin-io/etcher/issues/296
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-04-13 12:12:19 -04:00
parent fd00a4ae0e
commit fedde73a02
2 changed files with 4 additions and 4 deletions

View File

@ -216,6 +216,7 @@ app.controller('AppController', function(
// "returns" to the first step.
self.selection.clear();
self.openImageSelector();
AnalyticsService.logEvent('Reselect image');
};
@ -224,7 +225,7 @@ app.controller('AppController', function(
return;
}
self.selection.removeDrive();
self.openDriveSelector();
AnalyticsService.logEvent('Reselect drive');
};

View File

@ -10,7 +10,7 @@
<p class="step-footer">*supported files: .img, .iso, .zip</p>
</div>
<div ng-show="app.selection.hasImage()">
<div ng-bind="app.selection.getImage() | basename" ng-click="app.reselectImage()"></div>
<div ng-bind="app.selection.getImage() | basename"></div>
<button class="btn btn-link step-footer"
ng-click="app.reselectImage()"
@ -44,8 +44,7 @@
</div>
<div ng-show="app.selection.hasDrive()">
<div ng-bind="app.selection.getDrive().name + ' - ' + app.selection.getDrive().size"
ng-click="app.reselectDrive()"></div>
<div ng-bind="app.selection.getDrive().name + ' - ' + app.selection.getDrive().size"></div>
<button class="btn btn-link step-footer"
ng-click="app.reselectDrive()"