mirror of
https://github.com/balena-io/etcher.git
synced 2025-04-19 21:07:18 +00:00
2291321b46
Etcher currently elevates a child writer proxy that itself spawns the Etcher CLI in robot mode, parses the output, and proxies those messages to the GUI application over IPC. After these set of changes, Etcher elevates a single child writer process that directly communicates back with the GUI using IPC. The main purpose behind these changes is to simplify the overall architecture and fix various issues caused by the current complex child process tree. Here's a summary of the changes: - Stop wrapping the Etcher CLI to perform writing - Remove the robot option from the Etcher CLI (along with related documentation) - Elevate a new `child-write.js` standalone executable - Move the relevant bits of `lib/child-writer` to the `image-writer` GUI module - Remove the `lib/child-writer` directory - Add a new "Child died unexpectedly" Mixpanel event - Floor state percentage in the flash state model The above changes made is possible to tackle all the remaining issues where the writer process would remain alive even if the parent died. Change-Type: patch Changelog-Entry: Ensure the writer process dies when the GUI application is killed. See: https://github.com/resin-io/etcher/pull/1873 See: https://github.com/resin-io/etcher/pull/1843 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
34 lines
1.3 KiB
JavaScript
34 lines
1.3 KiB
JavaScript
/*
|
|
* Copyright 2016 resin.io
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
'use strict'
|
|
|
|
// See http://electron.atom.io/docs/v0.37.7/api/environment-variables/#electronrunasnode
|
|
//
|
|
// Notice that if running electron with `ELECTRON_RUN_AS_NODE`, the binary
|
|
// *won't* attempt to load the `app.asar` application by default, therefore
|
|
// if passing `ELECTRON_RUN_AS_NODE`, you have to pass the path to the asar
|
|
// or the entry point file (this file) manually as an argument.
|
|
//
|
|
// We also consider `ATOM_SHELL_INTERNAL_RUN_AS_NODE`, which is basically
|
|
// an older equivalent of `ELECTRON_RUN_AS_NODE` that still gets set when
|
|
// using `child_process.fork()`.
|
|
if (process.env.ELECTRON_RUN_AS_NODE || process.env.ATOM_SHELL_INTERNAL_RUN_AS_NODE) {
|
|
require('./gui/modules/child-writer')
|
|
} else {
|
|
require('./gui/etcher')
|
|
}
|