From 01e4414d179b2739d3499e579738c57d5cf4868d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20S=C3=B8rensen?= Date: Fri, 26 Feb 2021 21:37:06 +0100 Subject: [PATCH] Ignore error if we are not connected (#8472) --- hassio/src/dashboard/hassio-update.ts | 6 +++++- .../src/dialogs/core/dialog-supervisor-core-update.ts | 8 +++++--- hassio/src/system/hassio-core-info.ts | 10 ++++++---- hassio/src/system/hassio-host-info.ts | 10 ++++++---- 4 files changed, 22 insertions(+), 12 deletions(-) diff --git a/hassio/src/dashboard/hassio-update.ts b/hassio/src/dashboard/hassio-update.ts index 13892bf5fc..7bbd6d6f73 100644 --- a/hassio/src/dashboard/hassio-update.ts +++ b/hassio/src/dashboard/hassio-update.ts @@ -159,7 +159,11 @@ export class HassioUpdate extends LitElement { } catch (err) { // Only show an error if the status code was not expected (user behind proxy) // or no status at all(connection terminated) - if (err.status_code && !ignoredStatusCodes.has(err.status_code)) { + if ( + this.hass.connection.connected && + err.status_code && + !ignoredStatusCodes.has(err.status_code) + ) { showAlertDialog(this, { title: "Update failed", text: extractApiErrorMessage(err), diff --git a/hassio/src/dialogs/core/dialog-supervisor-core-update.ts b/hassio/src/dialogs/core/dialog-supervisor-core-update.ts index 5dce6082d5..0b1453c397 100644 --- a/hassio/src/dialogs/core/dialog-supervisor-core-update.ts +++ b/hassio/src/dialogs/core/dialog-supervisor-core-update.ts @@ -130,9 +130,11 @@ class DialogSupervisorCoreUpdate extends LitElement { try { await updateCore(this.hass); } catch (err) { - this._error = extractApiErrorMessage(err); - this._action = null; - return; + if (this.hass.connection.connected) { + this._error = extractApiErrorMessage(err); + this._action = null; + return; + } } fireEvent(this, "supervisor-colllection-refresh", { colllection: "core" }); this.closeDialog(); diff --git a/hassio/src/system/hassio-core-info.ts b/hassio/src/system/hassio-core-info.ts index e3c455e510..21ab1c84b6 100644 --- a/hassio/src/system/hassio-core-info.ts +++ b/hassio/src/system/hassio-core-info.ts @@ -140,10 +140,12 @@ class HassioCoreInfo extends LitElement { try { await restartCore(this.hass); } catch (err) { - showAlertDialog(this, { - title: "Failed to restart Home Assistant Core", - text: extractApiErrorMessage(err), - }); + if (this.hass.connection.connected) { + showAlertDialog(this, { + title: "Failed to restart Home Assistant Core", + text: extractApiErrorMessage(err), + }); + } } finally { button.progress = false; } diff --git a/hassio/src/system/hassio-host-info.ts b/hassio/src/system/hassio-host-info.ts index 2abe3a74cb..dd4b7932ca 100644 --- a/hassio/src/system/hassio-host-info.ts +++ b/hassio/src/system/hassio-host-info.ts @@ -342,10 +342,12 @@ class HassioHostInfo extends LitElement { await updateOS(this.hass); fireEvent(this, "supervisor-colllection-refresh", { colllection: "os" }); } catch (err) { - showAlertDialog(this, { - title: "Failed to update", - text: extractApiErrorMessage(err), - }); + if (this.hass.connection.connected) { + showAlertDialog(this, { + title: "Failed to update", + text: extractApiErrorMessage(err), + }); + } } button.progress = false; }