jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-27 11:16:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stabilize step flow errors (#26258)

Browse Source
This commit is contained in:
karwosts 2025-07-22 22:33:48 -07:00 committed by GitHub
parent c13a80ce5e
commit 07c7b07362
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/dialogs/config-flow/step-flow-form.ts
View File

@ -37,8 +37,14 @@ class StepFlowForm extends LitElement {
@state() private _stepData?: Record<string, any>; @state() private _stepData?: Record<string, any>;
@state() private _previewErrors?: Record<string, string>;
@state() private _submitErrors?: Record<string, string>;
@state() private _errorMsg?: string; @state() private _errorMsg?: string;
private _errors?: Record<string, string>;
public disconnectedCallback(): void { public disconnectedCallback(): void {
super.disconnectedCallback(); super.disconnectedCallback();
this.removeEventListener("keydown", this._handleKeyDown); this.removeEventListener("keydown", this._handleKeyDown);
@ -72,7 +78,7 @@ class StepFlowForm extends LitElement {
.schema=${autocompleteLoginFields( .schema=${autocompleteLoginFields(
this.handleReadOnlyFields(step.data_schema) this.handleReadOnlyFields(step.data_schema)
)} )}
.error=${step.errors} .error=${this._errors}
.computeLabel=${this._labelCallback} .computeLabel=${this._labelCallback}
.computeHelper=${this._helperCallback} .computeHelper=${this._helperCallback}
.computeError=${this._errorCallback} .computeError=${this._errorCallback}
@ -119,7 +125,7 @@ class StepFlowForm extends LitElement {
} }
private _setError(ev: CustomEvent) { private _setError(ev: CustomEvent) {
this.step = { ...this.step, errors: ev.detail }; this._previewErrors = ev.detail;
} }
protected firstUpdated(changedProps: PropertyValues) { protected firstUpdated(changedProps: PropertyValues) {
@ -133,6 +139,21 @@ class StepFlowForm extends LitElement {
if (changedProps.has("step") && this.step?.preview) { if (changedProps.has("step") && this.step?.preview) {
import(`./previews/flow-preview-${previewModule(this.step.preview)}`); import(`./previews/flow-preview-${previewModule(this.step.preview)}`);
} }
if (
changedProps.has("step") ||
changedProps.has("_previewErrors") ||
changedProps.has("_submitErrors")
) {
this._errors =
this.step.errors || this._previewErrors || this._submitErrors
? {
...this.step.errors,
...this._previewErrors,
...this._submitErrors,
}
: undefined;
}
} }
private _clickHandler(ev: MouseEvent) { private _clickHandler(ev: MouseEvent) {
@ -189,6 +210,7 @@ class StepFlowForm extends LitElement {
this._loading = true; this._loading = true;
this._errorMsg = undefined; this._errorMsg = undefined;
this._submitErrors = undefined;
const flowId = this.step.flow_id; const flowId = this.step.flow_id;
@ -217,6 +239,7 @@ class StepFlowForm extends LitElement {
return; return;
} }
this._previewErrors = undefined;
fireEvent(this, "flow-update", { fireEvent(this, "flow-update", {
step, step,
}); });
@ -226,7 +249,7 @@ class StepFlowForm extends LitElement {
this._errorMsg = err.body.message; this._errorMsg = err.body.message;
} }
if (err.body.errors) { if (err.body.errors) {
this.step = { ...this.step, errors: err.body.errors }; this._submitErrors = err.body.errors;
} }
if (!err.body.message && !err.body.errors) { if (!err.body.message && !err.body.errors) {
this._errorMsg = "Unknown error occurred"; this._errorMsg = "Unknown error occurred";