review comments

This commit is contained in:
Ian Richardson 2019-02-12 17:30:50 -06:00
parent e8d84e8ba5
commit 08222dfbec
2 changed files with 6 additions and 6 deletions

View File

@ -12,7 +12,7 @@ import { fireEvent } from "../../../../common/dom/fire_event";
class HuiNotificationsButton extends LitElement { class HuiNotificationsButton extends LitElement {
@property() public notifications?: string[]; @property() public notifications?: string[];
@property() public open?: boolean; @property() public opened?: boolean;
protected render(): TemplateResult | void { protected render(): TemplateResult | void {
return html` return html`
@ -43,8 +43,8 @@ class HuiNotificationsButton extends LitElement {
} }
private _clicked() { private _clicked() {
this.open = true; this.opened = true;
fireEvent(this, "open-changed"); fireEvent(this, "opened", { value: this.opened });
} }
} }

View File

@ -60,7 +60,7 @@ let loadedUnusedEntities = false;
declare global { declare global {
// tslint:disable-next-line // tslint:disable-next-line
interface HASSDomEvents { interface HASSDomEvents {
"open-changed": {}; opened: {};
} }
} }
@ -193,8 +193,8 @@ class HUIRoot extends LitElement {
<div main-title>${this.config.title || "Home Assistant"}</div> <div main-title>${this.config.title || "Home Assistant"}</div>
<hui-notifications-button <hui-notifications-button
.hass="${this.hass}" .hass="${this.hass}"
.open="${this._notificationsOpen}" .opened="${this._notificationsOpen}"
@open-changed="${this._handleNotificationsOpenChanged}" @opened="${this._handleNotificationsOpenChanged}"
.notifications="${this._notifications}" .notifications="${this._notifications}"
></hui-notifications-button> ></hui-notifications-button>
<ha-start-voice-button <ha-start-voice-button