jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-11-09 10:59:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pickers not getting focus (#14068)

Browse Source 
* fix focus pickers

* await nextRender instead of setTimeout

* use bram's code

* Update src/components/ha-target-picker.ts

Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>

Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>
This commit is contained in:
Travis Collins
2022-10-17 03:01:17 -06:00
committed by GitHub
parent dad7c43fd2
commit 0972cb4583
5 changed files with 33 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/components/ha-area-picker.ts
View File

@@ -116,16 +116,14 @@ export class HaAreaPicker extends SubscribeMixin(LitElement) {
];
}
public open() {
this.updateComplete.then(() => {
this.comboBox?.open();
});
public async open() {
await this.updateComplete;
await this.comboBox?.open();
}
public focus() {
this.updateComplete.then(() => {
this.comboBox?.focus();
});
public async focus() {
await this.updateComplete;
await this.comboBox?.focus();
}
private _getAreas = memoizeOne(
@@ -290,7 +288,7 @@ export class HaAreaPicker extends SubscribeMixin(LitElement) {
protected updated(changedProps: PropertyValues) {
if (
(!this._init && this._devices && this._areas && this._entities) ||
(changedProps.has("_opened") && this._opened)
(this._init && changedProps.has("_opened") && this._opened)
) {
this._init = true;
(this.comboBox as any).items = this._getAreas(
@@ -308,9 +306,6 @@ export class HaAreaPicker extends SubscribeMixin(LitElement) {
}
protected render(): TemplateResult {
if (!this._devices || !this._areas || !this._entities) {
return html``;
}
return html`
<ha-combo-box
.hass=${this.hass}