jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-29 20:26:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ll-rebuild only keeps the card that should be deleted (#2481)

Browse Source 
* Fix ll-rebuild only keeps the card that should be deleted

* Do the same thing for stack cards. (Untested. Leeeeroyyyyy Jenkins)

* Copy then replace instead of mutating

* Use map
This commit is contained in:
Thomas Lovén 2019-01-15 18:30:33 +01:00 committed by Paulus Schoutsen
parent f943366ecd
commit 0ddc82601a
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/panels/lovelace/cards/hui-stack-card.ts
View File

@ -75,15 +75,13 @@ export abstract class HuiStackCard extends LitElement implements LovelaceCard {
} }
private _rebuildCard( private _rebuildCard(
element: LovelaceCard, cardElToReplace: LovelaceCard,
config: LovelaceCardConfig config: LovelaceCardConfig
): void { ): void {
const newCard = this._createCardElement(config); const newCardEl = this._createCardElement(config);
element.replaceWith(newCard); cardElToReplace.parentElement!.replaceChild(newCardEl, cardElToReplace);
this._cards = this._cards!.splice( this._cards = this._cards!.map((curCardEl) =>
this._cards!.indexOf(element), curCardEl === cardElToReplace ? newCardEl : curCardEl
1,
newCard
); );
} }
} }

10
src/panels/lovelace/hui-view.ts
View File

@ -306,12 +306,14 @@ export class HUIView extends hassLocalizeLitMixin(LitElement) {
} }
private _rebuildCard( private _rebuildCard(
element: LovelaceCard, cardElToReplace: LovelaceCard,
config: LovelaceCardConfig config: LovelaceCardConfig
): void { ): void {
const newCard = this._createCardElement(config); const newCardEl = this._createCardElement(config);
element.parentElement!.replaceChild(newCard, element); cardElToReplace.parentElement!.replaceChild(newCardEl, cardElToReplace);
this._cards = this._cards.splice(this._cards.indexOf(element), 1, newCard); this._cards = this._cards!.map((curCardEl) =>
curCardEl === cardElToReplace ? newCardEl : curCardEl
);
} }
} }