jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-11-16 22:40:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Webrtc use RTCIceCandidateInit messages with backend (#22667)

Browse Source 
* Add sdp m line index to ICE Candidates

* Remove ? from candidate

Co-authored-by: Bram Kragten <mail@bramkragten.nl>

* Send full candidate in message

* Revert launch.json change

* Use RTCIceCandidate for messaging

---------

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This commit is contained in:
Steven B.
2024-11-23 12:56:19 +00:00
committed by GitHub
parent 528fcecd16
commit 10b8627f51
2 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/components/ha-web-rtc-player.ts
View File

@@ -54,7 +54,7 @@ class HaWebRtcPlayer extends LitElement {
private _sessionId?: string;
private _candidatesList: string[] = [];
private _candidatesList: RTCIceCandidate[] = [];
protected override render(): TemplateResult {
if (this._error) {
@@ -252,7 +252,8 @@ class HaWebRtcPlayer extends LitElement {
this.hass,
this.entityid!,
event.session_id,
candidate
// toJSON returns RTCIceCandidateInit
candidate.toJSON()
)
);
this._candidatesList = [];
@@ -266,9 +267,17 @@ class HaWebRtcPlayer extends LitElement {
this._logEvent("remote ice candidate", event.candidate);
try {
await this._peerConnection?.addIceCandidate(
new RTCIceCandidate({ candidate: event.candidate, sdpMid: "0" })
);
// The spdMid or sdpMLineIndex is required so set sdpMid="0" if not
// sent from the backend.
const candidate =
event.candidate.sdpMid || event.candidate.sdpMLineIndex != null
? new RTCIceCandidate(event.candidate)
: new RTCIceCandidate({
candidate: event.candidate.candidate,
sdpMid: "0",
});
await this._peerConnection?.addIceCandidate(candidate);
} catch (err: any) {
// eslint-disable-next-line no-console
console.error(err);
@@ -285,17 +294,22 @@ class HaWebRtcPlayer extends LitElement {
return;
}
this._logEvent("local ice candidate", event.candidate?.candidate);
this._logEvent(
"local ice candidate",
event.candidate?.candidate,
event.candidate?.sdpMLineIndex
);
if (this._sessionId) {
addWebRtcCandidate(
this.hass,
this.entityid,
this._sessionId,
event.candidate?.candidate
// toJSON returns RTCIceCandidateInit
event.candidate.toJSON()
);
} else {
this._candidatesList.push(event.candidate?.candidate);
this._candidatesList.push(event.candidate);
}
};