jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-11 03:16:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1807 from home-assistant/safer-icon-brightness

Browse Source 
Safer brightness calculation for icons
This commit is contained in:
Zack Arnett 2018-10-19 20:58:46 -04:00 committed by GitHub
commit 11f4564465
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/entity/state-badge.js
View File

@ -68,6 +68,7 @@ class StateBadge extends PolymerElement {
} }
_updateIconAppearance(newVal) { _updateIconAppearance(newVal) {
var errorMessage = null;
const iconStyle = { const iconStyle = {
color: "", color: "",
filter: "", filter: "",
@ -88,12 +89,21 @@ class StateBadge extends PolymerElement {
} }
if (newVal.attributes.brightness) { if (newVal.attributes.brightness) {
const brightness = newVal.attributes.brightness; const brightness = newVal.attributes.brightness;
if (typeof brightness !== "number") {
errorMessage = `Type error: state-badge expected number, but type of ${
newVal.entity_id
}.attributes.brightness is ${typeof brightness} (${brightness})`;
console.warn(errorMessage);
}
// lowest brighntess will be around 50% (that's pretty dark) // lowest brighntess will be around 50% (that's pretty dark)
iconStyle.filter = `brightness(${(brightness + 245) / 5}%)`; iconStyle.filter = `brightness(${(brightness + 245) / 5}%)`;
} }
} }
Object.assign(this.$.icon.style, iconStyle); Object.assign(this.$.icon.style, iconStyle);
Object.assign(this.style, hostStyle); Object.assign(this.style, hostStyle);
if (errorMessage) {
throw new Error(`Frontend error: ${errorMessage}`);
}
} }
} }
customElements.define("state-badge", StateBadge); customElements.define("state-badge", StateBadge);