From 89f33a1730efd8d0da98e1ee7eccda0666a7edf6 Mon Sep 17 00:00:00 2001 From: Ian Richardson Date: Fri, 15 Nov 2019 09:45:50 -0600 Subject: [PATCH 1/2] Fix entity-filter-badge update --- .../lovelace/badges/hui-entity-filter-badge.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/panels/lovelace/badges/hui-entity-filter-badge.ts b/src/panels/lovelace/badges/hui-entity-filter-badge.ts index eb569aafc9..428faeda40 100644 --- a/src/panels/lovelace/badges/hui-entity-filter-badge.ts +++ b/src/panels/lovelace/badges/hui-entity-filter-badge.ts @@ -109,11 +109,14 @@ class EntityFilterBadge extends HTMLElement implements LovelaceBadge { return; } - // Attach element if it has never been attached. - if (!this.lastChild) { - for (const element of this._elements) { - this.appendChild(element); - } + let child = this.lastElementChild; + while (child) { + this.removeChild(child); + child = this.lastElementChild; + } + + for (const element of this._elements) { + this.appendChild(element); } this.style.display = "inline"; From 562d7a7cf4e9b527d34b8ad3911d61e18f4ec48d Mon Sep 17 00:00:00 2001 From: Ian Richardson Date: Fri, 15 Nov 2019 11:10:47 -0600 Subject: [PATCH 2/2] use lastChild --- src/panels/lovelace/badges/hui-entity-filter-badge.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/panels/lovelace/badges/hui-entity-filter-badge.ts b/src/panels/lovelace/badges/hui-entity-filter-badge.ts index 428faeda40..444ec7d3f6 100644 --- a/src/panels/lovelace/badges/hui-entity-filter-badge.ts +++ b/src/panels/lovelace/badges/hui-entity-filter-badge.ts @@ -109,10 +109,8 @@ class EntityFilterBadge extends HTMLElement implements LovelaceBadge { return; } - let child = this.lastElementChild; - while (child) { - this.removeChild(child); - child = this.lastElementChild; + while (this.lastChild) { + this.removeChild(this.lastChild); } for (const element of this._elements) {