From 1bb62bfc05a8ed8eed61de4ff9db4707efa1da38 Mon Sep 17 00:00:00 2001
From: Jack Wilsdon <jack.wilsdon@gmail.com>
Date: Mon, 19 Nov 2018 10:59:10 +0000
Subject: [PATCH] Only add a separating colon if there is a valid prefix and
 suffix (#2060)

This commit changes the media player entity row to only add a colon
separator to the status line when there is both a prefix and a suffix.
---
 .../hui-media-player-entity-row.js            | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js b/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js
index 32b92ff82e..c123618852 100644
--- a/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js
+++ b/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js
@@ -103,22 +103,27 @@ class HuiMediaPlayerEntityRow extends LocalizeMixin(PolymerElement) {
   _computeMediaTitle(stateObj) {
     if (!stateObj || this._isOff(stateObj.state)) return null;
 
+    let prefix;
+    let suffix;
+
     switch (stateObj.attributes.media_content_type) {
       case "music":
-        return `${stateObj.attributes.media_artist}: ${
-          stateObj.attributes.media_title
-        }`;
+        prefix = stateObj.attributes.media_artist;
+        suffix = stateObj.attributes.media_title;
+        break;
       case "tvshow":
-        return `${stateObj.attributes.media_series_title}: ${
-          stateObj.attributes.media_title
-        }`;
+        prefix = stateObj.attributes.media_series_title;
+        suffix = stateObj.attributes.media_title;
+        break;
       default:
-        return (
+        prefix =
           stateObj.attributes.media_title ||
           stateObj.attributes.app_name ||
-          stateObj.state
-        );
+          stateObj.state;
+        suffix = "";
     }
+
+    return prefix && suffix ? `${prefix}: ${suffix}` : prefix || suffix || "";
   }
 
   _computeState(state) {