jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-25 18:26:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix suffix in zwave config panel, send config on change instead of input (#15779)

Browse Source
This commit is contained in:
Bram Kragten 2023-03-13 11:47:44 +01:00 committed by GitHub
parent 3abc5c42d0
commit 1bc7bb0169
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-node-config.ts
View File

@ -18,7 +18,6 @@ import {
import { customElement, property, state } from "lit/decorators"; import { customElement, property, state } from "lit/decorators";
import { classMap } from "lit/directives/class-map"; import { classMap } from "lit/directives/class-map";
import memoizeOne from "memoize-one"; import memoizeOne from "memoize-one";
import { debounce } from "../../../../../common/util/debounce";
import "../../../../../components/ha-alert"; import "../../../../../components/ha-alert";
import "../../../../../components/ha-card"; import "../../../../../components/ha-card";
import "../../../../../components/ha-icon-next"; import "../../../../../components/ha-icon-next";
@ -210,7 +209,7 @@ class ZWaveJSNodeConfig extends SubscribeMixin(LitElement) {
</em>` </em>`
: ""} : ""}
${result?.status ${result?.status
? html` <p ? html`<p
class="result ${classMap({ class="result ${classMap({
[result.status]: true, [result.status]: true,
})}" })}"
@ -264,11 +263,9 @@ class ZWaveJSNodeConfig extends SubscribeMixin(LitElement) {
.propertyKey=${item.property_key} .propertyKey=${item.property_key}
.key=${id} .key=${id}
.disabled=${!item.metadata.writeable} .disabled=${!item.metadata.writeable}
@input=${this._numericInputChanged} @change=${this._numericInputChanged}
.suffix=${item.metadata.unit}
> >
${item.metadata.unit
? html`<span slot="suffix">${item.metadata.unit}</span>`
: ""}
</ha-textfield>`; </ha-textfield>`;
} }
@ -340,12 +337,6 @@ class ZWaveJSNodeConfig extends SubscribeMixin(LitElement) {
this._updateConfigParameter(ev.target, Number(ev.target.value)); this._updateConfigParameter(ev.target, Number(ev.target.value));
} }
private debouncedUpdate = debounce((target, value) => {
this._config![target.key].value = value;
this._updateConfigParameter(target, value);
}, 1000);
private _numericInputChanged(ev) { private _numericInputChanged(ev) {
if (ev.target === undefined || this._config![ev.target.key] === undefined) { if (ev.target === undefined || this._config![ev.target.key] === undefined) {
return; return;
@ -355,7 +346,7 @@ class ZWaveJSNodeConfig extends SubscribeMixin(LitElement) {
return; return;
} }
this.setResult(ev.target.key, undefined); this.setResult(ev.target.key, undefined);
this.debouncedUpdate(ev.target, value); this._updateConfigParameter(ev.target, value);
} }
private async _updateConfigParameter(target, value) { private async _updateConfigParameter(target, value) {