jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-20 15:56:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix duplicate items in sortables (#7053)

Browse Source
This commit is contained in:
Bram Kragten 2020-09-18 17:28:19 +02:00 committed by GitHub
parent 357df2bf68
commit 1ffa87ea23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/ha-sidebar.ts
View File

@ -539,17 +539,25 @@ class HaSidebar extends LitElement {
this._hiddenPanels = [...this._hiddenPanels, panel]; this._hiddenPanels = [...this._hiddenPanels, panel];
this._renderEmptySortable = true; this._renderEmptySortable = true;
await this.updateComplete; await this.updateComplete;
const container = this.shadowRoot!.getElementById("sortable")!;
while (container.lastElementChild) {
container.removeChild(container.lastElementChild);
}
this._renderEmptySortable = false; this._renderEmptySortable = false;
} }
private async _unhidePanel(ev: Event) { private async _unhidePanel(ev: Event) {
ev.preventDefault(); ev.preventDefault();
const panel = (ev.currentTarget as any).panel; const panel = (ev.currentTarget as any).panel;
this._renderEmptySortable = true;
await this.updateComplete;
this._hiddenPanels = this._hiddenPanels.filter( this._hiddenPanels = this._hiddenPanels.filter(
(hidden) => hidden !== panel (hidden) => hidden !== panel
); );
this._renderEmptySortable = true;
await this.updateComplete;
const container = this.shadowRoot!.getElementById("sortable")!;
while (container.lastElementChild) {
container.removeChild(container.lastElementChild);
}
this._renderEmptySortable = false; this._renderEmptySortable = false;
} }

4
src/panels/lovelace/components/hui-entity-editor.ts
View File

@ -123,6 +123,10 @@ export class HuiEntityEditor extends LitElement {
private async _handleEntitiesChanged() { private async _handleEntitiesChanged() {
this._renderEmptySortable = true; this._renderEmptySortable = true;
await this.updateComplete; await this.updateComplete;
const container = this.shadowRoot!.querySelector(".entities")!;
while (container.lastElementChild) {
container.removeChild(container.lastElementChild);
}
this._renderEmptySortable = false; this._renderEmptySortable = false;
} }