From 24509425cab18929aa9bafe39c37e3950bbe54ff Mon Sep 17 00:00:00 2001 From: Steve Repsher Date: Sat, 20 Aug 2022 13:36:58 -0400 Subject: [PATCH] Fix some localize key type errors in lovelace editors (#13403) --- .../get-headerfooter-stub-config.ts | 2 +- src/panels/lovelace/editor/types.ts | 4 ++-- .../lovelace/editor/view-editor/hui-view-editor.ts | 12 +++++++----- src/panels/lovelace/header-footer/types.ts | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/panels/lovelace/editor/header-footer-editor/get-headerfooter-stub-config.ts b/src/panels/lovelace/editor/header-footer-editor/get-headerfooter-stub-config.ts index dd6132ee0b..d1705e6643 100644 --- a/src/panels/lovelace/editor/header-footer-editor/get-headerfooter-stub-config.ts +++ b/src/panels/lovelace/editor/header-footer-editor/get-headerfooter-stub-config.ts @@ -4,7 +4,7 @@ import { LovelaceHeaderFooterConfig } from "../../header-footer/types"; export const getHeaderFooterStubConfig = async ( hass: HomeAssistant, - type: string, + type: LovelaceHeaderFooterConfig["type"], entities: string[], entitiesFallback: string[] ): Promise => { diff --git a/src/panels/lovelace/editor/types.ts b/src/panels/lovelace/editor/types.ts index 821c2dabcb..998c33b6a0 100644 --- a/src/panels/lovelace/editor/types.ts +++ b/src/panels/lovelace/editor/types.ts @@ -64,7 +64,7 @@ export interface Card { } export interface HeaderFooter { - type: string; + type: LovelaceHeaderFooterConfig["type"]; icon?: string; } @@ -75,7 +75,7 @@ export interface CardPickTarget extends EventTarget { export interface SubElementEditorConfig { index?: number; elementConfig?: LovelaceRowConfig | LovelaceHeaderFooterConfig; - type: string; + type: "header" | "footer" | "row"; } export interface EditSubElementEvent { diff --git a/src/panels/lovelace/editor/view-editor/hui-view-editor.ts b/src/panels/lovelace/editor/view-editor/hui-view-editor.ts index 8f34499782..323e6dab96 100644 --- a/src/panels/lovelace/editor/view-editor/hui-view-editor.ts +++ b/src/panels/lovelace/editor/view-editor/hui-view-editor.ts @@ -48,11 +48,13 @@ export class HuiViewEditor extends LitElement { name: "type", selector: { select: { - options: [ - DEFAULT_VIEW_LAYOUT, - SIDEBAR_VIEW_LAYOUT, - PANEL_VIEW_LAYOUT, - ].map((type) => ({ + options: ( + [ + DEFAULT_VIEW_LAYOUT, + SIDEBAR_VIEW_LAYOUT, + PANEL_VIEW_LAYOUT, + ] as const + ).map((type) => ({ value: type, label: localize( `ui.panel.lovelace.editor.edit_view.types.${type}` diff --git a/src/panels/lovelace/header-footer/types.ts b/src/panels/lovelace/header-footer/types.ts index a13cfc2401..45ff294723 100644 --- a/src/panels/lovelace/header-footer/types.ts +++ b/src/panels/lovelace/header-footer/types.ts @@ -2,7 +2,7 @@ import { ActionConfig } from "../../../data/lovelace"; import { EntitiesCardEntityConfig } from "../cards/types"; export interface LovelaceHeaderFooterConfig { - type: string; + type: "buttons" | "graph" | "picture"; } export interface ButtonsHeaderFooterConfig extends LovelaceHeaderFooterConfig {