jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-27 03:06:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-Authored-By: balloob <paulus@home-assistant.io>
This commit is contained in:
Ian Richardson 2018-12-11 19:05:01 +01:00 committed by GitHub
parent 5a5a7dad1e
commit 27bb175624
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/panels/lovelace/hui-root.ts
View File

@ -262,7 +262,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
`; `;
} }
protected renderStyle() { protected renderStyle(): TemplateResult {
if (!this._haStyle) { if (!this._haStyle) {
this._haStyle = document.importNode( this._haStyle = document.importNode(
(document.getElementById("ha-style")! (document.getElementById("ha-style")!
@ -421,14 +421,14 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
this.routeData = ev.detail.value; this.routeData = ev.detail.value;
} }
private _handleNotificationsOpenChanged(ev) { private _handleNotificationsOpenChanged(ev): void {
this.notificationsOpen = ev.detail.value; this.notificationsOpen = ev.detail.value;
} }
private _updateNotifications( private _updateNotifications(
states: HassEntities, states: HassEntities,
persistent: Array<unknown> persistent: Array<unknown>
) { ): Array<unknown> {
const configurator = computeNotifications(states); const configurator = computeNotifications(states);
return persistent.concat(configurator); return persistent.concat(configurator);
} }
@ -437,7 +437,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
fireEvent(this, "config-refresh"); fireEvent(this, "config-refresh");
} }
private _handleUnusedEntities() { private _handleUnusedEntities(): void {
this._selectView("unused"); this._selectView("unused");
} }
@ -445,7 +445,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
ev.target.selected = null; ev.target.selected = null;
} }
private _handleHelp() { private _handleHelp(): void {
window.open("https://www.home-assistant.io/lovelace/", "_blank"); window.open("https://www.home-assistant.io/lovelace/", "_blank");
} }
@ -460,7 +460,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
} }
} }
private _editModeDisable() { private _editModeDisable(): void {
this.lovelace!.setEditMode(false); this.lovelace!.setEditMode(false);
if (this.config.views.length < 2) { if (this.config.views.length < 2) {
fireEvent(this, "iron-resize"); fireEvent(this, "iron-resize");
@ -489,7 +489,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
this._navigateView(index); this._navigateView(index);
} }
private _navigateView(viewIndex) { private _navigateView(viewIndex: number): void {
if (viewIndex !== this._curView) { if (viewIndex !== this._curView) {
const path = this.config.views[viewIndex].path || viewIndex; const path = this.config.views[viewIndex].path || viewIndex;
navigate(this, `/lovelace/${path}`); navigate(this, `/lovelace/${path}`);
@ -497,7 +497,7 @@ class HUIRoot extends hassLocalizeLitMixin(LitElement) {
scrollToTarget(this, this._layout.header.scrollTarget); scrollToTarget(this, this._layout.header.scrollTarget);
} }
private _selectView(viewIndex) { private _selectView(viewIndex: number): void {
this._curView = viewIndex; this._curView = viewIndex;
// Recreate a new element to clear the applied themes. // Recreate a new element to clear the applied themes.