Add guard for when default url is not available (#8593)

This commit is contained in:
Bram Kragten 2021-03-09 11:56:26 +01:00 committed by GitHub
parent ca3cac4ed3
commit 2e76b306c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 48 additions and 27 deletions

View File

@ -9,7 +9,8 @@ import {
TemplateResult, TemplateResult,
} from "lit-element"; } from "lit-element";
import { HomeAssistant } from "../types"; import { HomeAssistant } from "../types";
import "./hass-subpage"; import "../components/ha-menu-button";
import "../components/ha-icon-button-arrow-prev";
@customElement("hass-error-screen") @customElement("hass-error-screen")
class HassErrorScreen extends LitElement { class HassErrorScreen extends LitElement {
@ -17,16 +18,29 @@ class HassErrorScreen extends LitElement {
@property({ type: Boolean }) public toolbar = true; @property({ type: Boolean }) public toolbar = true;
@property({ type: Boolean }) public rootnav = false;
@property() public narrow?: boolean;
@property() public error?: string; @property() public error?: string;
protected render(): TemplateResult { protected render(): TemplateResult {
return html` return html`
${this.toolbar ${this.toolbar
? html`<div class="toolbar"> ? html`<div class="toolbar">
<ha-icon-button-arrow-prev ${this.rootnav
.hass=${this.hass} ? html`
@click=${this._handleBack} <ha-menu-button
></ha-icon-button-arrow-prev> .hass=${this.hass}
.narrow=${this.narrow}
></ha-menu-button>
`
: html`
<ha-icon-button-arrow-prev
.hass=${this.hass}
@click=${this._handleBack}
></ha-icon-button-arrow-prev>
`}
</div>` </div>`
: ""} : ""}
<div class="content"> <div class="content">

View File

@ -16,13 +16,13 @@ import { HomeAssistant } from "../types";
@customElement("hass-loading-screen") @customElement("hass-loading-screen")
class HassLoadingScreen extends LitElement { class HassLoadingScreen extends LitElement {
@property({ attribute: false }) public hass?: HomeAssistant;
@property({ type: Boolean, attribute: "no-toolbar" }) @property({ type: Boolean, attribute: "no-toolbar" })
public noToolbar = false; public noToolbar = false;
@property({ type: Boolean }) public rootnav = false; @property({ type: Boolean }) public rootnav = false;
@property({ attribute: false }) public hass?: HomeAssistant;
@property() public narrow?: boolean; @property() public narrow?: boolean;
protected render(): TemplateResult { protected render(): TemplateResult {

View File

@ -7,6 +7,7 @@ import {
import { customElement, property, PropertyValues } from "lit-element"; import { customElement, property, PropertyValues } from "lit-element";
import { deepActiveElement } from "../common/dom/deep-active-element"; import { deepActiveElement } from "../common/dom/deep-active-element";
import { deepEqual } from "../common/util/deep-equal"; import { deepEqual } from "../common/util/deep-equal";
import { getDefaultPanel } from "../data/panel";
import { CustomPanelInfo } from "../data/panel_custom"; import { CustomPanelInfo } from "../data/panel_custom";
import { HomeAssistant, Panels } from "../types"; import { HomeAssistant, Panels } from "../types";
import { removeInitSkeleton } from "../util/init-skeleton"; import { removeInitSkeleton } from "../util/init-skeleton";
@ -37,25 +38,6 @@ const COMPONENTS = {
import("../panels/media-browser/ha-panel-media-browser"), import("../panels/media-browser/ha-panel-media-browser"),
}; };
const getRoutes = (panels: Panels): RouterOptions => {
const routes: RouterOptions["routes"] = {};
Object.values(panels).forEach((panel) => {
const data: RouteOptions = {
tag: `ha-panel-${panel.component_name}`,
cache: CACHE_URL_PATHS.includes(panel.url_path),
};
if (panel.component_name in COMPONENTS) {
data.load = COMPONENTS[panel.component_name];
}
routes[panel.url_path] = data;
});
return {
showLoading: true,
routes,
};
};
@customElement("partial-panel-resolver") @customElement("partial-panel-resolver")
class PartialPanelResolver extends HassRouterPage { class PartialPanelResolver extends HassRouterPage {
@property({ attribute: false }) public hass!: HomeAssistant; @property({ attribute: false }) public hass!: HomeAssistant;
@ -144,6 +126,31 @@ class PartialPanelResolver extends HassRouterPage {
} }
} }
private getRoutes(panels: Panels): RouterOptions {
const routes: RouterOptions["routes"] = {};
Object.values(panels).forEach((panel) => {
const data: RouteOptions = {
tag: `ha-panel-${panel.component_name}`,
cache: CACHE_URL_PATHS.includes(panel.url_path),
};
if (panel.component_name in COMPONENTS) {
data.load = COMPONENTS[panel.component_name];
}
routes[panel.url_path] = data;
});
return {
beforeRender: (page) => {
if (!page || !routes[page]) {
return getDefaultPanel(this.hass).url_path;
}
return undefined;
},
showLoading: true,
routes,
};
}
private _onHidden() { private _onHidden() {
this._hiddenTimeout = window.setTimeout(() => { this._hiddenTimeout = window.setTimeout(() => {
this._hiddenTimeout = undefined; this._hiddenTimeout = undefined;
@ -191,7 +198,7 @@ class PartialPanelResolver extends HassRouterPage {
} }
private async _updateRoutes(oldPanels?: HomeAssistant["panels"]) { private async _updateRoutes(oldPanels?: HomeAssistant["panels"]) {
this.routerOptions = getRoutes(this.hass.panels); this.routerOptions = this.getRoutes(this.hass.panels);
if ( if (
!this._waitForStart && !this._waitForStart &&