Fix tap to toggle sidebar (#7049)

This commit is contained in:
Bram Kragten 2020-09-18 12:17:10 +02:00 committed by GitHub
parent 40bffc1d25
commit 32b9c1eba1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -237,7 +237,7 @@ class HaSidebar extends LitElement {
? html` ? html`
<mwc-icon-button <mwc-icon-button
.label=${hass.localize("ui.sidebar.sidebar_toggle")} .label=${hass.localize("ui.sidebar.sidebar_toggle")}
@click=${this._toggleSidebar} @action=${this._toggleSidebar}
> >
<ha-svg-icon <ha-svg-icon
.path=${hass.dockedSidebar === "docked" .path=${hass.dockedSidebar === "docked"
@ -544,15 +544,12 @@ class HaSidebar extends LitElement {
private async _unhidePanel(ev: Event) { private async _unhidePanel(ev: Event) {
ev.preventDefault(); ev.preventDefault();
const index = this._hiddenPanels.indexOf((ev.currentTarget as any).panel); const panel = (ev.currentTarget as any).panel;
if (index < 0) {
return;
}
this._hiddenPanels.splice(index, 1);
// Make a copy for Memoize
this._hiddenPanels = [...this._hiddenPanels];
this._renderEmptySortable = true; this._renderEmptySortable = true;
await this.updateComplete; await this.updateComplete;
this._hiddenPanels = this._hiddenPanels.filter(
(hidden) => hidden !== panel
);
this._renderEmptySortable = false; this._renderEmptySortable = false;
} }
@ -648,7 +645,10 @@ class HaSidebar extends LitElement {
}); });
} }
private _toggleSidebar() { private _toggleSidebar(ev: CustomEvent) {
if (ev.detail.action !== "tap") {
return;
}
fireEvent(this, "hass-toggle-menu"); fireEvent(this, "hass-toggle-menu");
} }