jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-08 09:56:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-add success/failure indicator on call service button in dev tools (#9600)

Browse Source 
* Re-add success/failure indicator on call service button in dev tools

* move success outside of try block

* Export HaProgressButton
This commit is contained in:
Raman Gupta 2021-07-26 17:59:49 -04:00 committed by GitHub
parent 982c940381
commit 32c6fb14dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/buttons/ha-progress-button.ts
View File

@ -5,7 +5,7 @@ import { customElement, property, query } from "lit/decorators";
import "../ha-circular-progress"; import "../ha-circular-progress";
@customElement("ha-progress-button") @customElement("ha-progress-button")
class HaProgressButton extends LitElement { export class HaProgressButton extends LitElement {
@property({ type: Boolean }) public disabled = false; @property({ type: Boolean }) public disabled = false;
@property({ type: Boolean }) public progress = false; @property({ type: Boolean }) public progress = false;

17
src/panels/developer-tools/service/developer-tools-service.ts
View File

@ -9,7 +9,8 @@ import { computeDomain } from "../../../common/entity/compute_domain";
import { computeObjectId } from "../../../common/entity/compute_object_id"; import { computeObjectId } from "../../../common/entity/compute_object_id";
import { hasTemplate } from "../../../common/string/has-template"; import { hasTemplate } from "../../../common/string/has-template";
import { extractSearchParam } from "../../../common/url/search-params"; import { extractSearchParam } from "../../../common/url/search-params";
import "../../../components/buttons/ha-progress-button"; import { HaProgressButton } from "../../../components/buttons/ha-progress-button";
import "../../../components/entity/ha-entity-picker"; import "../../../components/entity/ha-entity-picker";
import "../../../components/ha-card"; import "../../../components/ha-card";
import "../../../components/ha-expansion-panel"; import "../../../components/ha-expansion-panel";
@ -135,11 +136,15 @@ class HaPanelDevService extends LitElement {
>` >`
: ""} : ""}
</div> </div>
<mwc-button .disabled=${!isValid} raised @click=${this._callService}> <ha-progress-button
.disabled=${!isValid}
raised
@click=${this._callService}
>
${this.hass.localize( ${this.hass.localize(
"ui.panel.developer-tools.tabs.services.call_service" "ui.panel.developer-tools.tabs.services.call_service"
)} )}
</mwc-button> </ha-progress-button>
</div> </div>
</div> </div>
@ -295,7 +300,8 @@ class HaPanelDevService extends LitElement {
} }
); );
private async _callService() { private async _callService(ev) {
const button = ev.currentTarget as HaProgressButton;
if (!this._serviceData?.service) { if (!this._serviceData?.service) {
return; return;
} }
@ -310,6 +316,7 @@ class HaPanelDevService extends LitElement {
return; return;
} }
forwardHaptic("failure"); forwardHaptic("failure");
button.actionError();
showToast(this, { showToast(this, {
message: message:
this.hass.localize( this.hass.localize(
@ -318,7 +325,9 @@ class HaPanelDevService extends LitElement {
this._serviceData.service this._serviceData.service
) + ` ${err.message}`, ) + ` ${err.message}`,
}); });
return;
} }
button.actionSuccess();
} }
private _toggleYaml() { private _toggleYaml() {