Use valid locale for translation test (#20899)

build-scripts/gulp/translations.js

@@ -19,6 +19,7 @@ const inBackendDir = "translations/backend";
 const workDir = "build/translations";
 const outDir = join(workDir, "output");
 const EN_SRC = join(paths.translations_src, "en.json");
+const TEST_LOCALE = "en-x-test";
 
 let mergeBackend = false;
 
@@ -150,7 +151,7 @@ const createTestTranslation = () =>
     : gulp
         .src(EN_SRC)
         .pipe(new CustomJSON(null, testReviver))
-        .pipe(rename("test.json"))
+        .pipe(rename(`${TEST_LOCALE}.json`))
         .pipe(gulp.dest(workDir));
 
 /**
@@ -192,7 +193,7 @@ const createTranslations = async () => {
   // each locale, then fragmentizes and flattens the data for final output.
   const translationFiles = await glob([
     `${inFrontendDir}/!(en).json`,
-    ...(env.isProdBuild() ? [] : [`${workDir}/test.json`]),
+    ...(env.isProdBuild() ? [] : [`${workDir}/${TEST_LOCALE}.json`]),
   ]);
   const hashStream = new Transform({
     objectMode: true,
@@ -254,8 +255,8 @@ const createTranslations = async () => {
     const mergeFiles = [];
     for (let i = 1; i <= subtags.length; i++) {
       const lang = subtags.slice(0, i).join("-");
-      if (lang === "test") {
+      if (lang === TEST_LOCALE) {
-        mergeFiles.push(`${workDir}/test.json`);
+        mergeFiles.push(`${workDir}/${TEST_LOCALE}.json`);
       } else if (lang !== "en") {
         mergeFiles.push(`${inFrontendDir}/${lang}.json`);
         if (mergeBackend) {
@@ -284,7 +285,7 @@ const writeTranslationMetaData = () =>
       new CustomJSON((meta) => {
         // Add the test translation in development.
         if (!env.isProdBuild()) {
-          meta.test = { nativeName: "Test" };
+          meta[TEST_LOCALE] = { nativeName: "Translation Test" };
         }
         // Filter out locales without a native name, and add the hashes.
         for (const locale of Object.keys(meta)) {

gallery/src/pages/date-time/date-time-numeric.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeDateTimeNumeric extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/date-time-seconds.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeDateTimeSeconds extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/date-time-short-year.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeDateTimeShortYear extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/date-time-short.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeDateTimeShort extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/date-time.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeDateTime extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/date.ts

@@ -35,9 +35,7 @@ export class DemoDateTimeDate extends LitElement {
           <div class="center">Month-Day-Year</div>
           <div class="center">Year-Month-Day</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/time-seconds.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeTimeSeconds extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/time-weekday.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeTimeWeekday extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

gallery/src/pages/date-time/time.ts

@@ -56,9 +56,7 @@ export class DemoDateTimeTime extends LitElement {
           <div class="center">12 Hours</div>
           <div class="center">24 Hours</div>
         </div>
-        ${Object.entries(translationMetadata.translations)
+        ${Object.entries(translationMetadata.translations).map(
-          .filter(([key, _]) => key !== "test")
-          .map(
           ([key, value]) => html`
             <div class="container">
               <div>${value.nativeName}</div>

src/common/number/format_number.ts

@@ -65,20 +65,10 @@ export const formatNumber = (
     localeOptions?.number_format !== NumberFormat.none &&
     !Number.isNaN(Number(num))
   ) {
-    try {
     return new Intl.NumberFormat(
       locale,
       getDefaultFormatOptions(num, options)
     ).format(Number(num));
-    } catch (err: any) {
-      // Don't fail when using "TEST" language
-      // eslint-disable-next-line no-console
-      console.error(err);
-      return new Intl.NumberFormat(
-        undefined,
-        getDefaultFormatOptions(num, options)
-      ).format(Number(num));
-    }
   }
 
   if (