jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-15 13:26:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid loading the whole entity registry for more info (#15627)

Browse Source
This commit is contained in:
J. Nick Koston 2023-02-28 03:58:45 -06:00 committed by GitHub
parent 20f2f5b317
commit 4031d9cc78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/dialogs/more-info/ha-more-info-info.ts
View File

@ -1,11 +1,6 @@
import { css, html, LitElement } from "lit"; import { css, html, LitElement } from "lit";
import { customElement, property, state } from "lit/decorators"; import { customElement, property } from "lit/decorators";
import { computeDomain } from "../../common/entity/compute_domain"; import { computeDomain } from "../../common/entity/compute_domain";
import { subscribeOne } from "../../common/util/subscribe-one";
import {
EntityRegistryEntry,
subscribeEntityRegistry,
} from "../../data/entity_registry";
import type { HomeAssistant } from "../../types"; import type { HomeAssistant } from "../../types";
import { import {
computeShowHistoryComponent, computeShowHistoryComponent,
@ -24,11 +19,10 @@ export class MoreInfoInfo extends LitElement {
@property() public entityId!: string; @property() public entityId!: string;
@state() private _entityEntry?: EntityRegistryEntry;
protected render() { protected render() {
const entityId = this.entityId; const entityId = this.entityId;
const stateObj = this.hass.states[entityId]; const stateObj = this.hass.states[entityId];
const entityRegObj = this.hass.entities[entityId];
const domain = computeDomain(entityId); const domain = computeDomain(entityId);
const newMoreInfo = computeShowNewMoreInfo(stateObj); const newMoreInfo = computeShowNewMoreInfo(stateObj);
@ -41,12 +35,12 @@ export class MoreInfoInfo extends LitElement {
)} )}
</ha-alert>` </ha-alert>`
: ""} : ""}
${stateObj?.attributes.restored && this._entityEntry ${stateObj?.attributes.restored && entityRegObj
? html`<ha-alert alert-type="warning"> ? html`<ha-alert alert-type="warning">
${this.hass.localize( ${this.hass.localize(
"ui.dialogs.more_info_control.restored.no_longer_provided", "ui.dialogs.more_info_control.restored.no_longer_provided",
{ {
integration: this._entityEntry.platform, integration: entityRegObj.platform,
} }
)} )}
</ha-alert>` </ha-alert>`
@ -86,17 +80,6 @@ export class MoreInfoInfo extends LitElement {
`; `;
} }
protected firstUpdated(changedProps) {
super.firstUpdated(changedProps);
subscribeOne(this.hass.connection, subscribeEntityRegistry).then(
(entries) => {
this._entityEntry = entries.find(
(entry) => entry.entity_id === this.entityId
);
}
);
}
static get styles() { static get styles() {
return css` return css`
.container { .container {