From 449751c59fa9a3c3c2aaefd94fa8eb382e4d41b6 Mon Sep 17 00:00:00 2001 From: c727 Date: Mon, 18 Jun 2018 19:04:12 +0200 Subject: [PATCH] Exp. UI: add errorHandling for CustomElement and getCardSize() (#1295) * Exp. UI: add errorHandling for CustomElement and getCardSize() * Add ";" * Lint --- src/panels/experimental-ui/hui-view.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/panels/experimental-ui/hui-view.js b/src/panels/experimental-ui/hui-view.js index 700750b071..ca722a4d86 100644 --- a/src/panels/experimental-ui/hui-view.js +++ b/src/panels/experimental-ui/hui-view.js @@ -102,6 +102,10 @@ class HUIView extends PolymerElement { // eslint-disable-next-line console.error('Unknown type encountered:', cardConfig.type); continue; + } else if (!customElements.get(tag)) { + // eslint-disable-next-line + console.error('Custom element doesn\'t exist:', tag); + continue; } const element = document.createElement(tag); element.config = cardConfig; @@ -152,8 +156,10 @@ class HUIView extends PolymerElement { return minIndex; } - elements.forEach(el => - columns[getColumnIndex(el.getCardSize())].push(el)); + elements.forEach((el) => { + const cardSize = typeof el.getCardSize === 'function' ? el.getCardSize() : 1; + columns[getColumnIndex(cardSize)].push(el); + }); // Remove empty columns columns = columns.filter(val => val.length > 0);